View Single Post

   
  #4 (permalink)  
Old 04-11-2008, 06:04 AM
Greg Sabino Mullane
 
Posts: n/a
Default Re: Last call for back-branch fixes


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> ! (void) sprintf((char *) rp, "\\\\%03o", *vp);
> ! (void) snprintf((char *) rp, 6, "\\\\%03o", *vp);


> Hardly looks like a critical fix, or even a needed one. Why bother?


No, not critical. Just something that tripped me up a few months ago when
writing some code based on this section, and I finally remembered it when
I saw your email. It's more of a nice to have, as the surrounding code
should prevent the %03o from making more than 3 characters.

- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200510032127
http://biglumber.com/x/web?pk=2529DF...9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFDQdq9vJuQZxSWSsgRAgeRAKCujcqJFtPf+LSlQ17BBC bGmfelmACgr30s
5OFfHfL3evrwV/FQI/XRMJI=
=ZTcO
-----END PGP SIGNATURE-----



---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Reply With Quote