View Single Post

   
  #3 (permalink)  
Old 04-11-2008, 06:21 AM
Tom Lane
 
Posts: n/a
Default Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

BTW, expanding on Andrew's comment, ISTM we could move the kernel call
out of the macro, ie make it look like

#define CHECK_FOR_INTERRUPTS() \
do { \
if (UNBLOCKED_SIGNAL_QUEUE()) \
pgwin32_check_queued_signals(); \
if (InterruptPending) \
ProcessInterrupts(); \
} while(0)

where pgwin32_check_queued_signals() is just

if (WaitForSingleObjectEx(pgwin32_signal_event,0,TRUE ) == WAIT_OBJECT_0)
pgwin32_dispatch_queued_signals();

This would save a few bytes at each call site while not really costing
anything in performance.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Reply With Quote