View Single Post

   
  #1 (permalink)  
Old 04-12-2008, 02:04 AM
Magnus Hagander
 
Posts: n/a
Default Re: pg_dump -Ft failed on Windows XP

> > Indeed, that's definitly a bug. Quick patch attached. It
> does appear
> > to work, but there may be a better way?

>
> This patch introduces a security hole because an attacker
> could create, say, a suitable symlink between the time the
> name is generated and the file is opened.


Good point. I guess what I need to do is use open() specifying O_CREATE,
and then fdopen() that file.

Question: Is the use of O_TEMPORARY to open() portable? (my win32 docs
say it will make the file automatically deleted when the last descriptor
is closed, which I didn't know before. That would make the patch much
simpler, but might require #ifdefs?)

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply With Quote