View Single Post

   
  #1 (permalink)  
Old 04-15-2008, 11:42 PM
Tom Lane
 
Posts: n/a
Default Re: contrib like modules in Red Hat problem, Re: A "bug" report for orafce

"Pavel Stehule" <pavel.stehule@gmail.com> writes:
> On 21/01/2008, Devrim GÜNDÜZ <devrim@commandprompt.com> wrote:
>> Orafce is about to be approved for Fedora, and I need help for one of
>> the review items. Per:
>> https://bugzilla.redhat.com/show_bug.cgi?id=251805#c1


AFAICT, there's nothing wrong with the Makefile. The problem is with
the specfile, which apparently is calling plain "make install".
It should read

%install
rm -rf $RPM_BUILD_ROOT

make DESTDIR=$RPM_BUILD_ROOT install

Devrim: you should be testing specfiles by building as non-root;
you would have caught this yourself.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply With Quote