View Single Post

   
  #1 (permalink)  
Old 04-15-2008, 11:48 PM
Tom Lane
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> Strengthen warnings about using pg_dump's -i option.


The proposed TODO item was not about doing this, it was about removing
the option altogether. AFAICS it's a foot-gun and nothing else --- why
do we have it?

BTW, a point I had forgotten is that pg_restore doesn't enforce that it
not be used with a newer server:

/* XXX Should get this from the archive */
AHX->minRemoteVersion = 070100;
AHX->maxRemoteVersion = 999999;

I think this is probably sane, since after all we couldn't enforce that
the plain script output not be loaded into a newer server. But it means
that -i is effectively a no-op for pg_restore, which again begs the
question of why we have it.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply With Quote