View Single Post

   
  #4 (permalink)  
Old 04-15-2008, 11:48 PM
Bruce Momjian
 
Posts: n/a
Default Re: Re: [COMMITTERS] pgsql: Strengthen warningsabout using pg_dump's -i option.

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> momjian@postgresql.org (Bruce Momjian) writes:
> >>> Strengthen warnings about using pg_dump's -i option.
> >>
> >> The proposed TODO item was not about doing this, it was about removing
> >> the option altogether. AFAICS it's a foot-gun and nothing else --- why
> >> do we have it?

>
> > I thought the simple fix was to just have a better warning and see how
> > that works in practice. There was some concern from people about
> > removing it without more feedback/warning. I am happy to remove it.

>
> My proposal would be to continue to accept the option but just ignore it
> (ie, error out on version mismatch whether or not -i is given). This
> way we wouldn't break any scripts that use the option, but things would
> still be safe.


A larger question is why the option was added in the first place.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply With Quote