View Single Post

   
  #7 (permalink)  
Old 04-15-2008, 11:22 PM
Oliver Jowett
 
Posts: n/a
Default Re: jdbc cts final diff for review

Dave Cramer wrote:
> Did you read my reasons for the ugly if double, then float stuff ?


Haven't had time to get my head around that yet.. can you translate it
to an explanation of something in the JDBC spec that we don't do
correctly? It's a bit hard to understand what's going wrong without the
CTS code to hand..

> I think it can be removed, however I think sooner than later we will be
> dealing
> with more complex parameters when stored procedures with real IN/OUT parms


Well, let's add the complexity only when we need it..

>> I still think they are redundant and should be entirely removed. We can
>> do that afterwards though.

>
> If absolutely necessary, however I don't think setObject with a
> different type is
> in the critical path


I'll hack on it if I have time after this is all applied; don't worry
about it for now since it's already in HEAD.

>> Why the repackaging?

>
> can't remember now.


Can you avoid repackaging then? Less CVS churn..

-O

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Reply With Quote