View Single Post

   
  #1 (permalink)  
Old 04-16-2008, 01:48 AM
Dave Page
 
Posts: n/a
Default Re: Odbcapi30.c - 64 bit compiler warning cleanup



> -----Original Message-----
> From: Ludek Finstrle [mailto:luf@pzkagis.cz]
> Sent: 27 January 2006 08:26
> To: Dave Page
> Cc: Tom Lane; pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] Odbcapi30.c - 64 bit compiler warning cleanup
>
> > > > The spec actually says it should be a SQLPOINTER.

> Changing to that
> > > > unleashes a whole barrel of extra fun unfortunately.
> > >
> > > I don't think it will be so problematic. I'll try it.

> It's the best way
> > > to support Win64.

> >
> > Here is my result. Patch attached. I have no 64-bit box

> ready at hand here.
> > I will test it on 64-bit box tomorrow.

>
> I find one problem. New patch attached. I get no warning with
> this one.
>
> Please review and comment


Looks good on 64 bit linux and Windows here.

BTW, in your version bump commit, you missed a bit in psqlodbc.rc:

FILEVERSION 8,1,1,8
PRODUCTVERSION 8,1,1,8

I've committed this, but just in case you weren't aware :-)

/D

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Reply With Quote