View Single Post

   
  #2 (permalink)  
Old 04-18-2008, 12:21 AM
Neil Conway
 
Posts: n/a
Default Re: bugfix - contrib/pgbench

ITAGAKI Takahiro wrote:
> --- 622,628 ----
> for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)
> {
> res = PQexec(con, DDLAFTERs[i]);
> ! if (strncmp(DDLAFTERs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)
> {
> fprintf(stderr, "%s", PQerrorMessage(con));
> exit(1);


None of the DDL in DDLAFTERs begins with "drop", so ISTM the right fix
is to just remove the strncmp().

-Neil

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

Reply With Quote