View Single Post

   
  #5 (permalink)  
Old 04-17-2008, 11:59 PM
Joe Conway
 
Posts: n/a
Default Re: [HACKERS] Patching dblink.c to avoid warning about

Tom Lane wrote:
> I think it would be shorter and clearer to write
>
> remoteConn *remconn = NULL;
> ...
> remconn = rconn;
> ...
> remconn->newXactForCursor = TRUE;
>
> Also, you might be able to combine this variable with the existing
> rconn local variable and thus simplify the code even more.


Thanks for the review Tom -- as usual, great suggestions. The attached
(simpler) patch makes use of your advice. If there are no objections,
I'll apply this tomorrow evening.

Joe


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Reply With Quote