View Single Post

   
  #2 (permalink)  
Old 04-18-2008, 12:15 AM
Neil Conway
 
Posts: n/a
Default Re: Uninstall scripts for contrib

On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote:
> *** contrib/chkpass/Makefile 27 Sep 2005 17:13:00 -0000 1.7
> --- contrib/chkpass/Makefile 14 Jan 2006 23:16:03 -0000
> ***************
> *** 1,9 ****
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20
> 20:13:02 momjian Exp $
>
> MODULE_big = chkpass
> OBJS = chkpass.o
> SHLIB_LINK = $(filter -lcrypt, $(LIBS))
> DATA_built = chkpass.sql
> DOCS = README.chkpass
>
> ifdef USE_PGXS
> --- 1,10 ----
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.7 2005/09/27
> 17:13:00 tgl Exp $
>
> MODULE_big = chkpass
> OBJS = chkpass.o
> SHLIB_LINK = $(filter -lcrypt, $(LIBS))
> DATA_built = chkpass.sql
> + DATA = uninstall.sql
> DOCS = README.chkpass
>
> ifdef USE_PGXS


The change to $PostgreSQL$ is bogus (perhaps due to the way you setup
cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also,
the patch doesn't actually add any files called "uninstall.sql".

-Neil



---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply With Quote