View Single Post

   
  #2 (permalink)  
Old 04-18-2008, 10:37 AM
Florian G. Pflug
 
Posts: n/a
Default Re: Rename latestCompletedXid to latestCommittedXid

Tom Lane wrote:
> "Florian G. Pflug" <fgp@phlo.org> writes:
>> Per my post to the hackers list, here is a patch that renamed
>> latestCompletedXid to latestCommittedXid, and updates it only
>> on commits.

>
> This is wrong --- it will break early detection of aborted
> subtransactions.


I don't see how - TransactionIdIsInProgress doesn't even touch
latestCompletedXid. And I didn't mess with XidCacheRemoveRunningXids,
other than removing the latestCompletedXid updating.

Am I missing something?

greetings, Florian Pflug


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Reply With Quote