View Single Post

   
  #2 (permalink)  
Old 04-19-2008, 06:23 AM
Merlin Moncure
 
Posts: n/a
Default Re: PQParam version 0.5

On Dec 5, 2007 2:44 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Andrew Chernow escribió:
>
> > Also changed PQputint8's prototype. Previously, it was using a void* as
> > the value argument, due to a lack of a portable 64-bit type in libpq. We
> > found an intersting way around this by using macro and variable argument
> > tricks.

>
> I didn't read the patch, but variadic macros are not portable. FWIW
> uint64 should "portable" to all platforms that have it (and it should be
> 32 bits on platforms that don't), but you have to watch for
> INT64_IS_BUSTED.


we don't use variadic macros...just a macro wrapper to a variadic function.

merlin

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Reply With Quote