View Single Post

   
  #2 (permalink)  
Old 04-19-2008, 06:25 AM
Bruce Momjian
 
Posts: n/a
Default Re: Remove FATAL from pg_lzdecompress


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Zdenek Kotala wrote:
>
> I attach patch which adds boundaries check and memory overwriting
> protection when compressed data are corrupted.
>
> Current behavior let code overwrite a memory and after that check if
> unpacked size is same as expected value. In this case elog execution
> fails (at least on Solaris - malloc has corrupted structures) and no
> message appears in a log file.
>
> I did not add any extra information into the message. Reasonable
> solution seems to be use errcontext how was recommended by Alvaro. But I
> 'm not sure if printtup is good place for it, because pg_detoast is
> called from many places. However, is can be solved in separate patch.
>
> I'm also think that this modification should be backported to other
> version too.
>
> Thanks Zdenek



>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend


--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your Subscription:
http://mail.postgresql.org/mj/mj_www...=pgsql-patches

Reply With Quote