View Single Post

   
  #1 (permalink)  
Old 04-29-2008, 08:31 PM
Alvaro Herrera
 
Posts: n/a
Default Re: Removing typename from A_Const (was: Empty arrayswith ARRAY[])

Brendan Jurd escribió:

> Here's my attempt to remove the typename field from A_Const. There
> were a few places (notably flatten_set_variable_args() in guc.c, and
> typenameTypeMod() in parse_type.c) where the code expected to see an
> A_Const with a typename, and I had to adjust for an A_Const within a
> TypeCast. Nonetheless, there was an overall net reduction of 34 lines
> of code, so I think this was a win.


Do say ... why don't we do away with A_Const altogether and just replace
it with Value? After this patch, I don't see what's the difference.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply With Quote