View Single Post

   
  #4 (permalink)  
Old 05-10-2008, 02:06 PM
Tom Lane
 
Posts: n/a
Default Re: [GENERAL] pgbench not setting scale size correctly?

Greg Smith <gsmith@gregsmith.com> writes:
> Turns out it wasn't so contorted. Updated patch attached that only warns
> in the exact cases where the setting is ignored, and the warning says how
> it's actually setting the scale.


It looks like the code could do with some refactoring. AFAICS
scale is stored into all the :scale variables at lines 1671-1691
(although not if you only have one client !?) only to be done over
again at lines 1746-1763 (though not if ttype != 3). Wasteful,
confusing, and there's a case where it fails to be done at all.
Sigh ...

regards, tom lane

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply With Quote