View Single Post

   
  #12 (permalink)  
Old 05-12-2008, 09:09 AM
Tom Lane
 
Posts: n/a
Default Re: bloated heapam.h

Alvaro Herrera <alvherre@commandprompt.com> writes:
> However, it seems the right fix is to move BufferGetPageSize and
> BufferGetPage from bufpage.h to bufmgr.h.


That sounds sane if it fixes the problem.

> (Digging further, it seems like bufpage.h should also include transam.h
> in order to get TransactionIdIsNormal ... I start to wonder how many
> problems of this nature we have on our headers. Without having a way to
> detect whether the defined macros are valid, it seems hard to check
> programatically, however.)


Yeah, I'm certain there's some other problems of the same kind, but I
don't see any easy way to find 'em.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply With Quote