SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-22-2008, 12:16 PM
| ||||
| ||||
 Re: diff: plug telldir/seekdir leaks and more Hey otto... Ive not tested this particular patch, but the previous one, that Paul wrote, worked well for me; no more memory leaks. Im a little bit swamped with work right now, so I cant really test the new patch. Cheers, Josh. Otto Moerbeek wrote: >On Fri, 24 Mar 2006, Otto Moerbeek wrote: > > > >>Hi, >> >>This is a revised version of the diff Paul Thorn >><pthorn-obsd@styx2002.no-ip.org> send some time ago. It's a mix of >>Paul's diff, FreeBSD code and my own: >> >>- plug a huge leak that occurs if telldir() is called, but no >>corresponding seekdir(). Samba is suffering from that. >>- Use a data structure local to DIR to store the telldir data. FreeBSD >>uses a linked list, I chose to use an array, which avoids allocating >>lots of small chunks, the index becomes implicit as well, so we can >>drop a field from the struct. >>- Make sure that loc = telldir(); .... seekdir(loc); telldir() returns loc, >>as POSIX requires. This is an area that can be improved, since it now >>scans the array. >> >>Note that one documented behaviour is changed. POSIX does not require >>it, and most other Unix-like system do not give that guarantee. >> >>Please review and test, especially on setup that uses telldir and >>seekdir. AFAIK, no program in base does that, but at least samba >>does. >> >> > >Not a single reply to this so far. There must be some samba users >hiding here. > >The diff is in snaps as well, to accomodate even easier testing. > >I'll crosspost this to misc@ as well, I know it's "not done", but I >really need test reports. > > -Otto      |
Linear Mode
