SEO
vBulletin Search Engine Optimization
| |||||||
![Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd.](http://unixadmintalk.com/iconimages/f19/re-patch-restore-native-use-isdigit-instead-ap_isdigit-httpd_ltr.gif)
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-22-2008, 12:16 PM
| ||||
| ||||
 Re: [Patch:] restore the native use of isdigit() instead of ap_isdigit() in httpd. On 3/30/06, Garance A Drosihn <drosih@rpi.edu> wrote: > The stupid thing in these routines is that the behavior is > UNDEFINED for values outside the correct range. We would > probably be doing ourselves (as programmers) a favor if we > made it a major error to pass in any negative value other > than the value for EOF. Many programmers have read the > description of these routines, and never quite understood > that these routines do *not* take a parameter of 'char'. i've thought about making all invalid values false. while the current openbsd implementation is safe, isdigit('1' + 256) returns true! something like int isdigit(int c) { return c == EOF ? 0 : c < CHAR_MIN ? 0 : c > UCHAR_MAX ? 0 : ((_ctype_ + 1)[(unsigned char)c] & _N)); }      |
 |
« Re: Suggested replacement of ap_snprintf with the native alternative snprintf with error check == Patch attached ==
|
[Patch] miss use of isdigit in httpd/src/support/logresolve.c »
| Thread Tools | |
| Display Modes | |
Linear Mode
|
|
All times are GMT. The time now is 05:24 AM.
