vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
| ||||
| * j knight <joel@openbsd.org> [2005-04-13 15:30]: > Daniel Hartmeier wrote: > >But maybe using two parameters is simpler, I'm not sure. There are three > >cases (add state tag, add no-refiltering tag, add no tag), so it would > >need two special values (not just 0), might be too ugly. > To do this you'd have to reserve a tag id in pf_ioctl.c:tagname2tag(). > This would also affect queue ids and I don't know if that could affect > some altq code somewhere (such as altq somewhere depending on queue ids > starting at 1, when we start at 2 and use 1 as the reserved value). there is no assumptions about the IDs (well, except that they are unique of course, and some regarding the name-ID mapping) whatsover. > Any thoughts? I think the seperate parameter is better. -- BS Web Services, http://www.bsws.de/ OpenBSD-based Webhosting, Mail Services, Managed Servers, ... Unix is very simple, but it takes a genius to understand the simplicity. (Dennis Ritchie) |