SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-22-2008, 12:39 PM
| ||||
| ||||
 Re: ucom(4) patch On Tue, Aug 22, 2006 at 07:23:31PM +0000, Miod Vallat wrote: > > I got kernel panics on detaching from cu(1) with wrong speed. > > ucomstart() tried to usbd_setup_xfern on already free'd sc->sc_oxfer > > What about moving ttyclose() into the spl protected section instead? and then of course doing the same for com(4) and pccom(4) (: > > Index: ucom.c > > ================================================== ================= > > RCS file: /cvs/src/sys/dev/usb/ucom.c,v > > retrieving revision 1.31 > > diff -u -r1.31 ucom.c > > --- ucom.c 2006/08/18 02:54:11 1.31 > > +++ ucom.c 2006/08/22 18:55:45 > > @@ -545,11 +545,11 @@ > > > > (*LINESW(tp, l_close))(tp, flag); > > s = spltty(); > > - ucom_cleanup(sc); > > CLR(tp->t_state, TS_BUSY | TS_FLUSH); > > sc->sc_cua = 0; > > splx(s); > > ttyclose(tp); > > + ucom_cleanup(sc); > > > > if (sc->sc_methods->ucom_close != NULL) > > sc->sc_methods->ucom_close(sc->sc_parent, sc->sc_portno); > -- paranoic mickey (my employers have changed but, the name has remained)      |
Linear Mode
