Unix Technical Forum

bad check in udf_hashins()

This is a discussion on bad check in udf_hashins() within the mailing.openbsd.tech forums, part of the OpenBSD category; --> I believe the pointer lh can never be null. Index: isofs/udf/udf_vnops.c ================================================== ================= RCS file: /cvs/src/sys/isofs/udf/udf_vnops.c,v retrieving revision 1.30 ...


Go Back   Unix Technical Forum > Unix Operating Systems > OpenBSD > mailing.openbsd.tech

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 02-18-2008, 09:34 AM
David Crawshaw
 
Posts: n/a
Default bad check in udf_hashins()

I believe the pointer lh can never be null.

Index: isofs/udf/udf_vnops.c
================================================== =================
RCS file: /cvs/src/sys/isofs/udf/udf_vnops.c,v
retrieving revision 1.30
diff -u -r1.30 udf_vnops.c
--- isofs/udf/udf_vnops.c 9 Dec 2007 20:54:01 -0000 1.30
+++ isofs/udf/udf_vnops.c 28 Dec 2007 18:23:19 -0000
@@ -133,8 +133,6 @@
vn_lock(up->u_vnode, LK_EXCLUSIVE | LK_RETRY, p);
mtx_enter(&ump->um_hashmtx);
lh = &ump->um_hashtbl[up->u_ino & ump->um_hashsz];
- if (lh == NULL)
- LIST_INIT(lh);
LIST_INSERT_HEAD(lh, up, u_le);
mtx_leave(&ump->um_hashmtx);

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 05:26 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com