Obvious pasto. Ok?

Prompted by http://permalink.gmane.org/gmane.os.openbsd.misc/146066
- I'm also wondering if AUTHKEYLEN in sys/net/if_sppp.h might be a
little on the low side.


Index: ifconfig.c
================================================== =================
RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.201
diff -u -p -r1.201 ifconfig.c
--- ifconfig.c 26 Jun 2008 05:42:06 -0000 1.201
+++ ifconfig.c 17 Jul 2008 07:49:57 -0000
@@ -3841,7 +3841,7 @@ setspppkey(const char *val, int d)
if (auth->proto == 0)
errx(1, "unspecified protocol");
if (strlcpy((char *)auth->secret, val, AUTHKEYLEN) >= AUTHKEYLEN)
- errx(1, "setspppname");
+ errx(1, "setspppkey");

spr.cmd = (int)SPPPIOSDEFS;
if (ioctl(s, SIOCSIFGENERIC, &ifr) == -1)

On Thu, Jul 17, 2008 at 12:53 AM, Stuart Henderson <stu@spacehopper.org> wrote:
> Obvious pasto. Ok?

ok canacar@

> Prompted by http://permalink.gmane.org/gmane.os.openbsd.misc/146066
> - I'm also wondering if AUTHKEYLEN in sys/net/if_sppp.h might be a
> little on the low side.

Yes, the present AUTHKEYLEN (16 characters) is a bit low. The
specification allows up to 255 characters (not explicitly but size is
a byte field). However, If we just increase it, we will break the ABI
again, and mbalmer@ will have the same upgrade problems

One alternative is merging 'secret and challenge' fields when sending
the password. This will increase the password size from 15 to 31
characters without changing the size of the structure.

thanks Can,

On 2008/07/17 11:48, Can Erkin Acar wrote:
> One alternative is merging 'secret and challenge' fields when sending
> the password. This will increase the password size from 15 to 31
> characters without changing the size of the structure.

That's a good idea. Though I have a feeling it may be trunk(4)'s
turn to break this time round ..

What does anyone think about changing the instructions for remote
upgrades? For several releases I've been backing up /sbin/reboot,
installing a new kernel and userland, then rebooting - this has
saved quite a few headaches for me...