SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-18-2008, 09:35 AM
| ||||
| ||||
 Re: diff(1) diff On Mon, Jan 14, 2008 at 02:24:05PM -0700, Marc Aurele La France wrote: > On Mon, 14 Jan 2008, Otto Moerbeek wrote: >> On Mon, Jan 14, 2008 at 04:14:12PM +0100, Tim van der Molen wrote: >>> On Mon, 14 Jan 2008 14:51:58 +0100, Otto Moerbeek wrote: >>>> On Mon, Jan 14, 2008 at 02:12:37PM +0100, Tim van der Molen wrote: >>>>> `diff -p' is searching for the relevant function prototype *outside* >>>>> the >>>>> context, but if the function prototype happens to be inside the >>>>> context, >>>>> then it won't be found. This diff makes the search begin at the changed >>>>> line itself. > >>>> Why repeat informatioon that is already shown in the context? I think >>>> it is quite reasnable the way it works now. > >>> Well, the point is not to repeat information, but to print correct >>> information. Also, searching inside the context doesn't introduce >>> drawbacks, does it? So why not do it if that can make diff(1) better >>> than `quite reasonable'? > >>> Yes, it's a small issue. But then, so is the diff. > >>> Anyway, thanks for your reply. > >> My point is, the if the declaration is in the context, it makes little >> sense to repeat it in the chunk header: > >> Take this example. From the context it is clear that we're changing >> mastercmp(). > > Devil's advocate argument: a script wouldn't think so. Come on, the -p mechanism is documented to be stupid. Nobody should rely on this info for script. -Otto > >> Index: ls.c >> ================================================== ================= >> RCS file: /cvs/src/bin/ls/ls.c,v >> retrieving revision 1.29 >> diff -u -p -r1.29 ls.c >> --- ls.c 7 May 2007 18:39:28 -0000 1.29 >> +++ ls.c 14 Jan 2008 16:47:59 -0000 >> @@ -567,7 +567,7 @@ display(FTSENT *p, FTSENT *list) >> static int >> mastercmp(const FTSENT **a, const FTSENT **b) >> { >> - int a_info, b_info; >> + int a_info, b_info; boo; >> >> a_info = (*a)->fts_info; >> if (a_info == FTS_ERR) > > Marc. > > +----------------------------------+----------------------------------+ > | Marc Aurele La France | work: 1-780-492-9310 | > | Academic Information and | fax: 1-780-492-1729 | > | Communications Technologies | email: tsi@ualberta.ca | > | 352 General Services Building +----------------------------------+ > | University of Alberta | | > | Edmonton, Alberta | Standard disclaimers apply | > | T6G 2H1 | | > | CANADA | | > +----------------------------------+----------------------------------+ > XFree86 developer and VP. ATI driver and X server internals.      |
Linear Mode
