Re: mv diff
This is a discussion on Re: mv diff within the mailing.openbsd.tech forums, part of the OpenBSD category; --> On Thu, Jul 26, 2007 at 01:29:21AM +0200, Artur Grabowski wrote: > Theo de Raadt <deraadt@cvs.openbsd.org> writes: > > ...
| |||||||
| FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-18-2008, 09:30 AM
| ||||
| ||||
 Re: mv diff On Thu, Jul 26, 2007 at 01:29:21AM +0200, Artur Grabowski wrote: > Theo de Raadt <deraadt@cvs.openbsd.org> writes: > > > Sorry, but I feel that these diffs which we get are just deck chair > > rearrangement. It does not fix anything. It just churns the code > > and creates room for other accidents to happen. I'm sure I am not > > alone when I say I am tired of us getting these kinds of diffs. > > > > Sometimes you will see various changes like this go in; but these > > changes go in while someone is busy look for REAL BUGS in the code. > > In this case, I just sense churn. > > I must say I agree totally. I'm doing a lot of those cleanup diffs, > mostly in the kernel, but it's always when I'm either reading the > code to find bugs or when preparing code for future changes. That's > also why you can find files where half the function prototypes are > ansified and the rest aren't and stuff like that. > > Just doing cleanups for the sake of cleanups strikes me as a huge > waste of talent. Find a bug instead. Then submit a cleanup just before > the bug fix. Or after. > > //art > Got it, I've been hinted afterwards about things I'd rather do. Thanks for clarifying -- sysadmin & coder @ http://www.evilkittens.org/ coder @ http://www.exalead.com/ [demime 1.01d removed an attachment of type application/pgp-signature]      |
Linear Mode
