Re: [patch] dd(1):dd.c does not close(2) files
This is a discussion on Re: [patch] dd(1):dd.c does not close(2) files within the mailing.openbsd.tech forums, part of the OpenBSD category; --> On Tue, Jul 31, 2007 at 01:44:56PM +0200, Mark Kettenis wrote: > > dd:args.c uses deprecated printf() modifier `q' ...
| |||||||
![Re: [patch] dd(1):dd.c does not close(2) files](http://www.unixadmintalk.com/iconimages/mailing-openbsd-tech/re-patch-dd-1-dd-c-does-not-close-2-files_ltr.gif)
| FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-18-2008, 09:31 AM
| ||||
| ||||
 Re: [patch] dd(1):dd.c does not close(2) files On Tue, Jul 31, 2007 at 01:44:56PM +0200, Mark Kettenis wrote: > > dd:args.c uses deprecated printf() modifier `q' (reserved for quad_t). > > It is used to print off_t value. Since off_t is defined as long long, > > maybe it is better to use `lld' modifier instead of `q'. There is also > > comparsion with QUAD_MAX constant. Maybe it will be also good to replace > > it with LLONG_MAX? > > While we certainly do not encourge the use of quad_t for new code, > there really isn't a point in making these changes in existing code > IMHO. This is a bug. The best approach from a standard point of view is the off_t argument to intmax_t and use %jd. Joerg      |
Linear Mode
