SEO
vBulletin Search Engine Optimization
| |||||||
![Re: [patch] libc - missing headers and unused vars](http://unixadmintalk.com/iconimages/f20/re-patch-libc-missing-headers-unused-vars_ltr.gif)
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-18-2008, 08:05 AM
| ||||
| ||||
 Re: [patch] libc - missing headers and unused vars On Mon, Oct 03, 2005 at 10:42:42AM -0400, Leonardo Chiquitto Filho wrote: > On Mon, Oct 03, 2005 at 07:41:22AM +0200, Marc Espie wrote: > > On Sun, Oct 02, 2005 at 08:42:33PM -0400, Leonardo Chiquitto Filho wrote: > > > Index: stdio/asprintf.c > > > ================================================== ================= > > > RCS file: /cvs/src/lib/libc/stdio/asprintf.c,v > > > retrieving revision 1.14 > > > diff -u -r1.14 asprintf.c > > > --- stdio/asprintf.c 8 Aug 2005 08:05:36 -0000 1.14 > > > +++ stdio/asprintf.c 1 Oct 2005 03:14:22 -0000 > > > @@ -18,6 +18,7 @@ > > > > > > #include <stdio.h> > > > #include <stdlib.h> > > > +#include <string.h> > > > #include <errno.h> > > > #include <stdarg.h> > > > #include "local.h" > > ... > > > > what problem does this solve ? > > All I see is that it makes libc take longer to compile. > > It just removes warnings like these: > asprintf.c: In function `asprintf': > asprintf.c:34: warning: implicit declaration of function `memset' > > I admit this is not a 'problem', but I think preventing this kind > of warnings contributes to the overall source code correctness. Oh, okay, it's a good patch, then. Sorry, I was under the impression you were just `uniformizing' the headers. I had not noticed these... they used not to warn on gcc <3, because of bugs in the way gcc handled built-ins.      |
Linear Mode
