Re: prettify the code a bit

#1 (**permalink**) 02-18-2008, 07:33 AM

On Wed, 2 Feb 2005 06:40:53 +0059
Han Boetes <han@mijncomputer.nl> wrote:

> > > - if (fd == 0)
> > > + if (fd == FILE_STDIO)
> >
> > I think you mean STDIN_FILENO. FILE_STDIO is used for something
> > else.
>
> I was following the logic of the rest of the file and 0 is used as
> FILE_STDIO:

So? 0 is the value of many constants. FILE_STDIO is used as the
way a file has been opened, not as the value for a specific file
descriptor.

> #define FILE_STDIO 0
> #define FILE_MMAP 1
> #define FILE_GZIP 2
>
> That's why I choose it. But indeed, your suggestion makes more
> sense.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode