On Fri, Feb 04, 2005 at 08:43:26AM +0100, Otto Moerbeek wrote:
>
> On Fri, 4 Feb 2005, Stephen Marley wrote:
>
> > Is this patch being considered for 3.7?
> >
> > http://marc.theaimsgroup.com/?l=open...6811107986&w=2
> >
> > It speeds up DNS writes by an order of magnitude, and looks very safe.
> >
> It might look safe, but the size of the diff does not say anything about
> it being safe or not. This really requires very wide testing, and we have
> no time left for that.

My assertion that the first patch looked safe was not based on the size
of the diff, rather for these reasons:

1. It doesn't add any code, but merely changes the logic of one
conditional so that it evaluates differently and the execution path
follows an already existing branch.

2. It has already been applied to NetBSD.

But if it's too late then it's too late.

Kind regards,
Stephen Marley

--
Network Systems Engineer, Datacentre Operations
Campbell Lee Internet Solutions <http://cl-is.com>