SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
02-18-2008, 07:50 AM
| ||||
| ||||
 Re: small source code beautification On Sat, May 14, 2005 at 04:07:34PM +0200, Toni Mueller wrote: > Index: radix.c > ================================================== ================= > RCS file: /cvs/src/sys/net/radix.c,v > retrieving revision 1.18 > diff -u -r1.18 radix.c > --- radix.c 25 Apr 2004 20:02:39 -0000 1.18 > +++ radix.c 10 May 2005 21:30:10 -0000 > @@ -105,9 +105,7 @@ > */ > > struct radix_node * > -rn_search(v_arg, head) > - void *v_arg; > - struct radix_node *head; > +rn_search (void *v_arg, struct radix_node *head) > { > struct radix_node *x; > caddr_t v; > [snipped the rest] This is not beautification. This is ANSIfication. :-) You have replaced old-C function calls (FORTRAN-like), with the new (if 1988 can be considered new) ANSI C function calls. However, you consistently put a space between a function name and (. Take a look at style(9) man page and change that. Functions: f(x) as you do in math because f(x) is a _SINGLE_ expression Control structures: if (conditional expression) { ... } while (conditional expression) { ... } here you need spaces to separate expression from keyword and brace Regards, Zvezdan Petkovic      |
Linear Mode
