Unix Technical Forum

Re: small source code beautification

This is a discussion on Re: small source code beautification within the mailing.openbsd.tech forums, part of the OpenBSD category; --> yes, I fixed that efore I committed * Jacob Meuser <jakemsr@jakemsr.com> [2005-05-15 23:41]: > On Sun, May 15, 2005 ...


Go Back   Unix Technical Forum > Unix Operating Systems > OpenBSD > mailing.openbsd.tech

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 02-18-2008, 07:50 AM
Henning Brauer
 
Posts: n/a
Default Re: small source code beautification

yes, I fixed that efore I committed

* Jacob Meuser <jakemsr@jakemsr.com> [2005-05-15 23:41]:
> On Sun, May 15, 2005 at 04:10:07PM +0200, Toni Mueller wrote:
>
> > Below you find the updated patch which should now be KNF-clean, with
> > all the advice given heeded (hopefully).

>
> > @@ -343,11 +328,8 @@
> > }
> >
> > struct radix_node *
> > -rn_insert(v_arg, head, dupentry, nodes)
> > - void *v_arg;
> > - struct radix_node_head *head;
> > - int *dupentry;
> > - struct radix_node nodes[2];
> > +rn_insert(void *v_arg, struct radix_node_head *head,
> > + int *dupentry, struct radix_node nodes[2])
> > {
> > caddr_t v = v_arg;
> > struct radix_node *top = head->rnh_treetop;

>
> since style(9) is being discussed, shouldn't long statemets that need
> two or more lines use a 4 space indent on the second and subsequent
> lines?
>
> --
> <jakemsr@jakemsr.com>
>


--
BS Web Services, http://www.bsws.de/
OpenBSD-based Webhosting, Mail Services, Managed Servers, ...
Unix is very simple, but it takes a genius to understand the simplicity.
(Dennis Ritchie)

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 10:05 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com