Re: src/lib/libc/stdlib/malloc.c

#1 (**permalink**) 02-18-2008, 10:25 AM

On 6/8/07, viking <brickviking@gmail.com> wrote:
> lines 19-21 seem to be pointless, as the preprocessor would attempt to
> undefine an already undefined symbol, or simply skip the lines if the symbol
> was already defined.
>
> I note the lines in question were picked up by someone else in FreeBSD's
> code back in 2005, before the massive malloc rewrite. That's nine years it
> had been in THAT code before removal. I've emailed the original author to
> ask about it; his reply is below:
>
> From phk (phk@freebsd.org)
> :They used to control some very paranoid consistency check code that
> :was removed pretty early on, unfortunately, those three lines got
> :missed somehow.

there are quite a few consistency checks still in the code that this
option enables. the ifndef undef bit is just a stylistic hint that
the option shouldn't be on. it's ok for it to not work.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode