Re: Two patches for lib/libc/db/hash/hash.c

Re: Two patches for lib/libc/db/hash/hash.c

This is a discussion on Re: Two patches for lib/libc/db/hash/hash.c within the mailing.openbsd.tech forums, part of the OpenBSD category; --> In message <20080406082118.GA19070@roppongi.boxsoft.com> so spake patrick keshishian (sidster): > Also, hashp->cndx is decremented (adjusted) during deletion of > the ...

		Unix Technical Forum > Unix Operating Systems > OpenBSD > mailing.openbsd.tech
Re: Two patches for lib/libc/db/hash/hash.c

#1 (permalink)

04-07-2008, 08:35 AM

Todd C. Miller

Posts: n/a

Re: Two patches for lib/libc/db/hash/hash.c

In message <20080406082118.GA19070@roppongi.boxsoft.com>
so spake patrick keshishian (sidster):

> Also, hashp->cndx is decremented (adjusted) during deletion of
> the key/data pair if hashp->cndx is pointing to the entry being
> deleted. The side-effect of not doing this is entries are
> skipped due to the way __delpair "shuffles" keys.

Looks reasonable, though I wonder if it would not be better to do
the cndx fixup inside __delpair() for the shuffle case.

- todd

« Re: -current kernel hangs (amd64/i386) - WAIT no_fltram5 | Re: better syntax highlight for make in vim »

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off Trackbacks are On Pingbacks are On Refbacks are On

Forum Jump

All times are GMT. The time now is 09:08 AM.