Re: Two patches for lib/libc/db/hash/hash.c
This is a discussion on Re: Two patches for lib/libc/db/hash/hash.c within the mailing.openbsd.tech forums, part of the OpenBSD category; --> On Sun, Apr 6, 2008 at 2:21 AM, patrick keshishian <sidster@boxsoft.com> wrote: .... > The first diff has nothing ...
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-07-2008, 08:36 AM
| ||||
| ||||
 Re: Two patches for lib/libc/db/hash/hash.c On Sun, Apr 6, 2008 at 2:21 AM, patrick keshishian <sidster@boxsoft.com> wrote: .... > The first diff has nothing to do with the above problem. It is > a sequence point evaluation fix. .... > rbufp->flags |= BUF_PIN; > - for (bp = (u_int16_t *)rbufp->page, n = *bp++, ndx = 1; ndx < n  > + bp = (u_int16_t *)rbufp->page; > + n = *bp++; > + for (ndx = 1; ndx < n {> if (bp[1] >= REAL_KEY) { Maybe I'm blind, but I don't see any sequence-point issues in the original code there: the comma operator introduces a sequence-point between the assignment to bp and the *bp++. Philip Guenther      |
Linear Mode
