On Thu, 2008-03-20 at 23:07 +0000, Simon Riggs wrote:

> > Simon, would it be too much to ask that you concentrate on reviewing
> > existing patches during commit fest? Trying to get people to think
> > about random new ideas is about the most direct undermining of the
> > commit-fest concept that I can think of. Save 'em for later.
>
> That's a fair reminder, thanks, I will do that.

I'm a bit in the dark about this Commit Fest, to be honest.

Is this the list of patches to be reviewed?
http://wiki.postgresql.org/wiki/Todo:CommitFest

I was suspicious of that because it mentions "Minor changes to Recovery
related code" by Simon Riggs, which I'd already mentioned had been
committed more than 6 months ago.

ISTM that nobody has reviewed anything except you, Tom, from the list.
Is that true, or are there others working on reviews I can't see?

or maybe the patch list is this?
http://wiki.postgresql.org/wiki/Todo:PatchStatus


I'll review Tom Doran's and Dany DeBontridder's work.

Incidentally, I'm in favour of letting Heikki review his own work
because there's a backlog on index changes that appears to be months
long and he has a good chance of tackling that.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Simon Riggs" <simon@2ndquadrant.com> writes:

> On Thu, 2008-03-20 at 23:07 +0000, Simon Riggs wrote:
>
>> > Simon, would it be too much to ask that you concentrate on reviewing
>> > existing patches during commit fest? Trying to get people to think
>> > about random new ideas is about the most direct undermining of the
>> > commit-fest concept that I can think of. Save 'em for later.
>>
>> That's a fair reminder, thanks, I will do that.
>
> I'm a bit in the dark about this Commit Fest, to be honest.
>
> Is this the list of patches to be reviewed?
> http://wiki.postgresql.org/wiki/Todo:CommitFest

That was labelled "experimental" and "in-progress". It was my attempt to dump
Bruces mailbox into the wiki. Unfortunately not enough information was present
in Bruce's pages to do that reasonably.

The "list" is at http://momjian.us/cgi-bin/pgpatches

It would be nice if we could remove the patches which have been reviewed or
applied from that list, but only Bruce can do that. Tom's berated Bruce once
for not focusing on the commitfest so I suspect that may happen soon.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's 24x7 Postgres support!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Simon Riggs wrote:
> On Thu, 2008-03-20 at 23:07 +0000, Simon Riggs wrote:
>
>>> Simon, would it be too much to ask that you concentrate on reviewing
>>> existing patches during commit fest? Trying to get people to think
>>> about random new ideas is about the most direct undermining of the
>>> commit-fest concept that I can think of. Save 'em for later.
>> That's a fair reminder, thanks, I will do that.
>
> I'm a bit in the dark about this Commit Fest, to be honest.
>
> Is this the list of patches to be reviewed?
> http://wiki.postgresql.org/wiki/Todo:CommitFest
>
> I was suspicious of that because it mentions "Minor changes to Recovery
> related code" by Simon Riggs, which I'd already mentioned had been
> committed more than 6 months ago.
>
> ISTM that nobody has reviewed anything except you, Tom, from the list.
> Is that true, or are there others working on reviews I can't see?
>
> or maybe the patch list is this?
> http://wiki.postgresql.org/wiki/Todo:PatchStatus
>
>
> I'll review Tom Doran's and Dany DeBontridder's work.
>
> Incidentally, I'm in favour of letting Heikki review his own work
> because there's a backlog on index changes that appears to be months
> long and he has a good chance of tackling that.

Umm, I don't think there's any patches from me in the queue that need
review. There's some discussion threads related to bitmap indexes, but
that's all. We're definitely not going to get bitmap indexes in this
commit fest.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Simon Riggs wrote:
> On Thu, 2008-03-20 at 23:07 +0000, Simon Riggs wrote:
>
> > > Simon, would it be too much to ask that you concentrate on reviewing
> > > existing patches during commit fest? Trying to get people to think
> > > about random new ideas is about the most direct undermining of the
> > > commit-fest concept that I can think of. Save 'em for later.
> >
> > That's a fair reminder, thanks, I will do that.
>
> I'm a bit in the dark about this Commit Fest, to be honest.
>
> Is this the list of patches to be reviewed?
> http://wiki.postgresql.org/wiki/Todo:CommitFest

I don't think that list is complete. The full archive is:

http://momjian.us/cgi-bin/pgpatches

Sorry, there is no summary.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, 2008-03-21 at 08:48 -0400, Bruce Momjian wrote:

> I don't think that list is complete. The full archive is:
>
> http://momjian.us/cgi-bin/pgpatches
>
> Sorry, there is no summary.

I've reviewed Nikhil's partitioning patch for now.

I have some time to contribute, but not much. I don't want to review
things that will be rejected for other reasons, so unless there is
clearer information I don't see how I can contribute further.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Heikki Linnakangas wrote:
> Simon Riggs wrote:
>>
>> Incidentally, I'm in favour of letting Heikki review his own work
>> because there's a backlog on index changes that appears to be months
>> long and he has a good chance of tackling that.
>
> Umm, I don't think there's any patches from me in the queue that need
> review. There's some discussion threads related to bitmap indexes, but
> that's all. We're definitely not going to get bitmap indexes in this
> commit fest.
>

There is your CopyReadLineText speedup, but I think there are too many
open questions on it, e.g.:

* should we change the line-end detection mode in text (non-CSV)
mode by looking for an LF preceded by an even number of
backslashes, or some similar logic?
* how do we decide when to use the memchr tests rather than char by
char tests?
* is there a more economical way to code the searcher? (although I
could live with it for now)


So I suggest we take it out of the queue for now and kick it back to you.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Heikki Linnakangas" <heikki@enterprisedb.com> writes:
> Umm, I don't think there's any patches from me in the queue that need
> review. There's some discussion threads related to bitmap indexes, but
> that's all. We're definitely not going to get bitmap indexes in this
> commit fest.

I think there are basically three types of work represented in the
current patch queue:

1. Actual patches that have some hope of being applied now, and if not
we are supposed to provide feedback about what's needed to fix them.

2. Design proposals that require further feedback. I think the idea
of the commit fest is that we should provide such feedback now, so
that whoever is going to work on it can proceed.

3. Discussions that don't really need any further feedback right now,
but should be summarized as TODO entries.

The reason category 3 is represented is that this is after all
Bruce's personal work queue (you'll remember that I pushed him to
open it up before he'd finished cleaning out that type of entry).

Personally I've been trying to knock off items in category 1.
It'd be useful for people to go through some of the longer discussion
threads and try to categorize them as needing further discussion now
or being just TODO items.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan <andrew@dunslane.net> writes:
> There is your CopyReadLineText speedup, but I think there are too many
> open questions on it, e.g.:
> ...
> So I suggest we take it out of the queue for now and kick it back to you.

Per my comments just now, the question is whether it's been adequately
reviewed or still needs some attention from the community. If we think
the ball's entirely in Heikki's court on it, then we're done with it
until he comes back with a new version (or evidence showing it's good
as-is).

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>
>> There is your CopyReadLineText speedup, but I think there are too many
>> open questions on it, e.g.:
>> ...
>> So I suggest we take it out of the queue for now and kick it back to you.
>>
>
> Per my comments just now, the question is whether it's been adequately
> reviewed or still needs some attention from the community. If we think
> the ball's entirely in Heikki's court on it, then we're done with it
> until he comes back with a new version (or evidence showing it's good
> as-is).
>
>
>

My comments were intended to say I think the latter is the case (since I
had previously undertaken to review this patch).

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> There is your CopyReadLineText speedup, but I think there are too many
>> open questions on it, e.g.:
>> ...
>> So I suggest we take it out of the queue for now and kick it back to you.
>
> Per my comments just now, the question is whether it's been adequately
> reviewed or still needs some attention from the community. If we think
> the ball's entirely in Heikki's court on it, then we're done with it
> until he comes back with a new version (or evidence showing it's good
> as-is).

I'm not expecting any more review in this commit fest.

My plan is to try special-casing the usual case of text-mode in a non
ASCII-embedding encoding (one that can be used as server encoding), by
using memchr() to find end of line first, and then scanning back from
there to count preceding backslashes. That requires some refactoring,
but should avoid the performance penalty when there's plenty of backslashes.

Of course, if anyeone has better ideas, please speak up!

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers