Unix Technical Forum

compiler warnings on the buildfarm

This is a discussion on compiler warnings on the buildfarm within the pgsql Hackers forums, part of the PostgreSQL category; --> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes: > E_FUNC_HAS_NO_RETURN_STMT is there because main is leaved by exit() instead > return. And In ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

Register FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #61 (permalink)  
Old 04-15-2008, 09:03 PM
Tom Lane
 
Posts: n/a
Default Re: compiler warnings on the buildfarm

Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> E_FUNC_HAS_NO_RETURN_STMT is there because main is leaved by exit() instead
> return. And In another case It should be regular warning.


That should be gone now; I changed the two places that triggered it.
I'd suggest not disabling that warning.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #62 (permalink)  
Old 04-15-2008, 09:03 PM
Zdenek Kotala
 
Posts: n/a
Default Re: compiler warnings on the buildfarm

Tom Lane napsal(a):
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>> E_FUNC_HAS_NO_RETURN_STMT is there because main is leaved by exit() instead
>> return. And In another case It should be regular warning.

>
> That should be gone now; I changed the two places that triggered it.
> I'd suggest not disabling that warning.


Yes I agree. Did you also clean up on old branches? If not I think we can live
with this warning on old branches.


Zdenek

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #63 (permalink)  
Old 04-15-2008, 09:03 PM
Tom Lane
 
Posts: n/a
Default Re: compiler warnings on the buildfarm

Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> Tom Lane napsal(a):
>> That should be gone now; I changed the two places that triggered it.
>> I'd suggest not disabling that warning.


> Yes I agree. Did you also clean up on old branches?


No, I'm not interested in doing that kind of fiddling on old branches.
I think we only care about warnings in HEAD. (Unless an actual bug is
exposed, of course, in which case we'd back-patch the fix as appropriate.)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 03:08 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com