SEO

#1 (**permalink**) 04-12-2008, 05:37 AM

In 8.2, utils/adt/formatting.c uses our NLS mechanism to localize day and
month names (I assume for use by to_char). But since this necessarily ties
the outcome to the LC_MESSAGES setting, this comes out inconsistently with
Unix locale behavior, e.g.,

pei@bell:~$ locale
LANG=
LC_CTYPE="POSIX"
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=

pei@bell:~$ date +%A
Friday

pei@bell:~$ LC_MESSAGES=de_DE@euro date +%A
Friday

pei@bell:~$ LC_TIME=de_DE@euro date +%A
Freitag

Is there no API to get the localized names from the C library so that LC_TIME
takes effect?

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

#2 (**permalink**) 04-12-2008, 05:38 AM

Peter Eisentraut wrote:

> pei@bell:~$ date +%A
> Friday
>
> pei@bell:~$ LC_MESSAGES=de_DE@euro date +%A
> Friday
>
> pei@bell:~$ LC_TIME=de_DE@euro date +%A
> Freitag
>
> Is there no API to get the localized names from the C library so that LC_TIME
> takes effect?
>
What about using strftime()? So we couldn't worry about gettext
translations; "all" is localized.
Why didn't I think it before? :-)

I'll try to code a patch today later if noone objects.

PS> I was thinking about changing this for the same reasons Peter
pointed out; I didn't have the time to do it before.

--
Euler Taveira de Oliveira
http://www.timbira.com/

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

#3 (**permalink**) 04-12-2008, 05:40 AM

Am Dienstag, 21. November 2006 00:52 schrieb Euler Taveira de Oliveira:
> Finished. Sorry for the delay I had some trouble understanding how
> backend treats the locale stuff (Neil pointed out the path).
> Now TM mode is returning strftime() output. It would be nice if in the
> future we change this to pg_strftime() but unfortunately the last one is
> not i18n.

What's concerning me about the way this is written is that it calls
setlocale() for each formatting instance, which will be very slow.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

#4 (**permalink**) 04-12-2008, 05:40 AM

Peter Eisentraut <peter_e@gmx.net> writes:
> What's concerning me about the way this is written is that it calls
> setlocale() for each formatting instance, which will be very slow.

Perhaps, the first time the info is needed, do setlocale(), ask strftime
for the 12+7 strings we need and save them away, then revert to C locale
and proceed from there.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

#5 (**permalink**) 04-12-2008, 05:40 AM

Peter Eisentraut wrote:
> Am Dienstag, 21. November 2006 00:52 schrieb Euler Taveira de Oliveira:
> > Finished. Sorry for the delay I had some trouble understanding how
> > backend treats the locale stuff (Neil pointed out the path).
> > Now TM mode is returning strftime() output. It would be nice if in the
> > future we change this to pg_strftime() but unfortunately the last one is
> > not i18n.

>
> What's concerning me about the way this is written is that it calls
> setlocale() for each formatting instance, which will be very slow.

Should we have it set from a guc hook on lc_time?

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#6 (**permalink**) 04-12-2008, 07:04 AM

Would someone update this patch with the optimization below. The patch
is at?

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > What's concerning me about the way this is written is that it calls
> > setlocale() for each formatting instance, which will be very slow.
>
> Perhaps, the first time the info is needed, do setlocale(), ask strftime
> for the 12+7 strings we need and save them away, then revert to C locale
> and proceed from there.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

Day and month name localization uses wrong locale category