Unix Technical Forum

partial dump of patch queue to wiki

This is a discussion on partial dump of patch queue to wiki within the pgsql Hackers forums, part of the PostgreSQL category; --> Hi, I created a page for our current commitfest: http://wiki.postgresql.org/wiki/CommitFest:March Not all patches are there yet. I only added ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-15-2008, 10:48 PM
Alvaro Herrera
 
Posts: n/a
Default partial dump of patch queue to wiki

Hi,

I created a page for our current commitfest:

http://wiki.postgresql.org/wiki/CommitFest:March

Not all patches are there yet. I only added the latest version of each
patch. I'll continue after lunch.

I also created one for the next commitfest:

http://wiki.postgresql.org/wiki/CommitFest:May

HTH

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-15-2008, 10:48 PM
Gregory Stark
 
Posts: n/a
Default Re: partial dump of patch queue to wiki

"Alvaro Herrera" <alvherre@commandprompt.com> writes:

> Hi,
>
> I created a page for our current commitfest:
>
> http://wiki.postgresql.org/wiki/CommitFest:March
>
> Not all patches are there yet. I only added the latest version of each
> patch. I'll continue after lunch.
>
> I also created one for the next commitfest:
>
> http://wiki.postgresql.org/wiki/CommitFest:May


Hm, at the same time as you were doing this I wrote a perl script to dump
Bruce's mail box into a table. The results are at:

http://wiki.postgresql.org/wiki/CommitFest:Bruce

I think the next step is to manually go through them and remove the comments,
replacing them with a single "status" cell. (And sending mail to the author
and -hackers with the meat of the review).

(Note that the "author" is just the author of the first message Bruce saved --
in some cases that's not the right person. And the "reviewer" is just the
author of the last comment.)

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-15-2008, 10:48 PM
Alvaro Herrera
 
Posts: n/a
Default Re: partial dump of patch queue to wiki

Gregory Stark wrote:

> Hm, at the same time as you were doing this I wrote a perl script to dump
> Bruce's mail box into a table. The results are at:


Heh. I should have guessed.


> http://wiki.postgresql.org/wiki/CommitFest:Bruce


It is a lot harder to trawl though ... I think it's easier to finish my
version than get the weed out of yours -- one reason my list is so much
shorter is that there was a huge lot of stuff in the patch queue that
has no actual patch; and there are multiple versions of certain patches.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-15-2008, 10:48 PM
Alvaro Herrera
 
Posts: n/a
Default Re: Wiki patch queue

Ok, AFAICT it is complete:

http://wiki.postgresql.org/wiki/CommitFest:March

It is a reasonably short page, so it's really easy to search for things
you might want to work on for this commit fest.

I also added the patches submitted on March 2008 to the May commitfest
page.

Patch submitters: please have a look at the current commitfest page and
check for possible nuisances.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-15-2008, 10:48 PM
Pavel Stehule
 
Posts: n/a
Default Re: Wiki patch queue

Hello

there is some noises about my patches

I sent EXECUTE USING - it's important (against to SQL injection and
faster dynamic SQL), this patch is linger time in queue.

variadic function, named params exist only as WIP and I see it for
next commit fest. I'll send new version in next months.

Regards
Pavel Stehule



On 25/03/2008, Alvaro Herrera <alvherre@commandprompt.com> wrote:
> Ok, AFAICT it is complete:
>
> http://wiki.postgresql.org/wiki/CommitFest:March
>
> It is a reasonably short page, so it's really easy to search for things
> you might want to work on for this commit fest.
>
> I also added the patches submitted on March 2008 to the May commitfest
> page.
>
> Patch submitters: please have a look at the current commitfest page and
> check for possible nuisances.
>
> --
> Alvaro Herrera http://www.CommandPrompt.com/
> The PostgreSQL Company - Command Prompt, Inc.
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-15-2008, 10:49 PM
Bruce Momjian
 
Posts: n/a
Default varadic patch


Because of this:

> variadic function, named params exist only as WIP and I see it for
> next commit fest. I'll send new version in next months.


This has been saved for the next commit-fest:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Pavel Stehule wrote:
> Hello
>
> there is some noises about my patches
>
> I sent EXECUTE USING - it's important (against to SQL injection and
> faster dynamic SQL), this patch is linger time in queue.
>
>
> Regards
> Pavel Stehule
>
>
>
> On 25/03/2008, Alvaro Herrera <alvherre@commandprompt.com> wrote:
> > Ok, AFAICT it is complete:
> >
> > http://wiki.postgresql.org/wiki/CommitFest:March
> >
> > It is a reasonably short page, so it's really easy to search for things
> > you might want to work on for this commit fest.
> >
> > I also added the patches submitted on March 2008 to the May commitfest
> > page.
> >
> > Patch submitters: please have a look at the current commitfest page and
> > check for possible nuisances.
> >
> > --
> > Alvaro Herrera http://www.CommandPrompt.com/
> > The PostgreSQL Company - Command Prompt, Inc.
> >
> >
> > --
> > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-hackers
> >

>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers


--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-15-2008, 10:49 PM
Alvaro Herrera
 
Posts: n/a
Default Re: varadic patch

Bruce Momjian escribió:
>
> Because of this:
>
> > variadic function, named params exist only as WIP and I see it for
> > next commit fest. I'll send new version in next months.

>
> This has been saved for the next commit-fest:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches_hold


Yes, it was already listed here:

http://wiki.postgresql.org/wiki/CommitFest:May

Upon verifying this I noticed that you broke all the permanent links the
other day, thus rendering both commitfest wiki pages useless -- just
fixed them. It would be nice that if you promise things to be
permanent, they are really permanent. Otherwise they are no better than
the other urls with message numbers.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-15-2008, 10:49 PM
Bruce Momjian
 
Posts: n/a
Default Re: varadic patch

Alvaro Herrera wrote:
> Bruce Momjian escribi??:
> >
> > Because of this:
> >
> > > variadic function, named params exist only as WIP and I see it for
> > > next commit fest. I'll send new version in next months.

> >
> > This has been saved for the next commit-fest:
> >
> > http://momjian.postgresql.org/cgi-bin/pgpatches_hold

>
> Yes, it was already listed here:
>
> http://wiki.postgresql.org/wiki/CommitFest:May
>
> Upon verifying this I noticed that you broke all the permanent links the
> other day, thus rendering both commitfest wiki pages useless -- just
> fixed them. It would be nice that if you promise things to be
> permanent, they are really permanent. Otherwise they are no better than
> the other urls with message numbers.


Can you give me an example of a link that changed? They shouldn't.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-15-2008, 10:49 PM
Alvaro Herrera
 
Posts: n/a
Default Re: varadic patch

Bruce Momjian escribió:
> Alvaro Herrera wrote:


> > Upon verifying this I noticed that you broke all the permanent links the
> > other day, thus rendering both commitfest wiki pages useless -- just
> > fixed them. It would be nice that if you promise things to be
> > permanent, they are really permanent. Otherwise they are no better than
> > the other urls with message numbers.

>
> Can you give me an example of a link that changed? They shouldn't.


They used to be
http://momjian.us/mhonarc/patches/16... mail.com.html

but now are
http://momjian.us/mhonarc/message-id... mail.com.html

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-15-2008, 10:49 PM
Tom Lane
 
Posts: n/a
Default Re: varadic patch

Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> I don't think the wiki pages should be relying on Bruce's queue at all
>> --- they should just link into the mail archives.


> Except the comments are on my queue, and they are updated to join
> threads by adding comments to patches posted months ago.


Well, as I told you yesterday, I don't see why you're expending large
amounts of effort to create facilities that already exist trivially
if the patch queue was just a bunch of URLs and comment text on a wiki
page. I feel that your current approach to the patch queue is dead
after this commit fest, so there's little point in putting so much work
into it.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:55 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com