"Joshua D. Drake" <jd@commandprompt.com> writes:
> I was just curious what the status of the Commit Fest was?

It's moving, but slowly. Bruce and I have been knocking items off
the queue, but we could use some help with reviewing.

http://momjian.us/cgi-bin/pgpatches

Please leave a comment if you're starting to work on anything
large, so that people don't duplicate effort.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> "Joshua D. Drake" <jd@commandprompt.com> writes:
>> I was just curious what the status of the Commit Fest was?
>
> It's moving, but slowly. Bruce and I have been knocking items off
> the queue, but we could use some help with reviewing.

Could you point me at a patch you think would make a good candidate? Or should
I just pick a random one?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's PostGIS support!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Gregory Stark <stark@enterprisedb.com> writes:
>> It's moving, but slowly. Bruce and I have been knocking items off
>> the queue, but we could use some help with reviewing.

> Could you point me at a patch you think would make a good candidate? Or should
> I just pick a random one?

Pick things you feel interested in and competent to review.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane wrote:
> "Joshua D. Drake" <jd@commandprompt.com> writes:
>
>> I was just curious what the status of the Commit Fest was?
>>
>
> It's moving, but slowly. Bruce and I have been knocking items off
> the queue, but we could use some help with reviewing.
>
> http://momjian.us/cgi-bin/pgpatches
>
> Please leave a comment if you're starting to work on anything
> large, so that people don't duplicate effort.
>
>
>

I can't say I find this an advance - paging through 14 pages of subject
headers with the odd comment isn't very productive. A nice wiki table
with links to the discussions would be much nicer, IMNSHO.

cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> http://momjian.us/cgi-bin/pgpatches

> I can't say I find this an advance - paging through 14 pages of subject
> headers with the odd comment isn't very productive. A nice wiki table
> with links to the discussions would be much nicer, IMNSHO.

Well, it's an advance over what we had before, which was that the queue
was completely read-only for everyone except Bruce. I agree that
migrating it to a wiki page would be nicer in the long run. But unless
someone wants to step up and make that happen within a very short
interval, trying to do it in the middle of the fest is just going to be
a distraction.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Joshua D. Drake" <jd@commandprompt.com> writes:
> Not it just looks like the same old patches threads

The comment stuff seems to need Javascript :-(

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

"Joshua D. Drake" <jd@commandprompt.com> writes:
> O.k. I have got to be doing something wrong. I always leave javascript
> on entirely. I am on this page:

> http://momjian.us/mhonarc/patches/msg00155.html

You can put comments on the top-level index pages --- actually they're
at the level of threads, not of individual messages. I'm not that
thrilled with that aspect of it myself, but it's still better than
nothing.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, 14 Mar 2008, Andrew Dunstan wrote:

> I can't say I find this an advance - paging through 14 pages of subject
> headers with the odd comment isn't very productive.

Bruce had said it was going to take him time to organize things better,
and instead of waiting for that to complete he was asked to just dump the
whole archive in there so other people could help. I didn't find the
formatting a problem. Many of the patches I had something to say about
were already sitting in my personal archived mailbox as well in the same
format, so I just switched to my mail reader to follow the threads better
in those cases.

> A nice wiki table with links to the discussions would be much nicer,
> IMNSHO.

Well then hurry up and take care of building that for everybody. One of
my better known catch phrases among my friends is "don't complain about
anything you're not willing to fix yourself".

I recall a moment from late in the 8.3 cycle that seems familiar here. I
went to the trouble of pushing some of the CVS commit information onto the
developer's wiki so that multiple people could help work through sorting
through it all as part of the release note building proces. But nobody
did, and Tom ended up doing the whole thing himself instead.

The lesson I walked away with is that if the person doing most of the work
isn't interested in your tool, what you and other people would like isn't
particularly relevant. While it's far from perfect, the comment thing on
these pages is a step forward, and I've spent a few hours sorting through
the parts of this I understand this week to try and help out with that.

Until someone other than Bruce and Tom is going to volunteer to do the
time consuming parts of the job, whether it would be nice to have this
information on a wiki or not doesn't matter too much. Usefully organized
content doesn't magically create itself, it takes work. I think once the
backlog is whittled down to a managable size moving to the wiki format
used to track 8.3 progress will make sense. Right now many of these
threads are not turning into patches to review, and the easiest way to
figure out which are which is to read through the discussion
thread--something a wiki wouldn't make any easier than the view Bruce is
already providing.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, 14 Mar 2008, Joshua D. Drake wrote:

> http://momjian.us/mhonarc/patches/msg00155.html
> This patch is actually one I think I could review but I see nothing
> that allows a comment or login to allow comment or anything.

To be specific, click on the "Thread Index" button at the top of that page
and you'll be taken to the view you leave comments on.

My biggest peeve with the software is that when I get e-mailed that
someone has replied to a comment I made, the URLs in the e-mail haven't
ever worked. I have to go sort through the messages manually to figure
out what the reply was referring to.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Greg Smith wrote:
> On Fri, 14 Mar 2008, Joshua D. Drake wrote:
>
> > http://momjian.us/mhonarc/patches/msg00155.html
> > This patch is actually one I think I could review but I see nothing
> > that allows a comment or login to allow comment or anything.
>
> To be specific, click on the "Thread Index" button at the top of that page
> and you'll be taken to the view you leave comments on.
>
> My biggest peeve with the software is that when I get e-mailed that
> someone has replied to a comment I made, the URLs in the e-mail haven't
> ever worked. I have to go sort through the messages manually to figure
> out what the reply was referring to.

Yea, that is a big problem because the URLs are dynamic. I have the
comments based on message id but there is no way to hook that to a URL.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers