Unix Technical Forum

Re: Commit fest?

This is a discussion on Re: Commit fest? within the pgsql Hackers forums, part of the PostgreSQL category; --> bruce wrote: > > Yea, that is a big problem because the URLs are dynamic. I have the > ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-15-2008, 11:47 PM
Bruce Momjian
 
Posts: n/a
Default Re: Commit fest?

bruce wrote:
> > Yea, that is a big problem because the URLs are dynamic. I have the
> > comments based on message id but there is no way to hook that to a URL.

>
> I have modified the code so each email message now shows a _permanent_
> URL at the top, e.g.
>
> Permanent URL: http://momjian.us/mhonarc/patches/44...isedb.com.html


I have shortened the URL using md5:

Permanent URL: http://momjian.us/mhonarc/patches/dd...66b9df9cd.html

So _now_ it is permanent. ;-)

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-15-2008, 11:47 PM
Gregory Stark
 
Posts: n/a
Default Re: Commit fest?

"Bruce Momjian" <bruce@momjian.us> writes:

> bruce wrote:
>> > Yea, that is a big problem because the URLs are dynamic. I have the
>> > comments based on message id but there is no way to hook that to a URL.

>>
>> I have modified the code so each email message now shows a _permanent_
>> URL at the top, e.g.
>>
>> Permanent URL: http://momjian.us/mhonarc/patches/44...isedb.com.html

>
> I have shortened the URL using md5:
>
> Permanent URL: http://momjian.us/mhonarc/patches/dd...66b9df9cd.html
>
> So _now_ it is permanent. ;-)


Not Found
The requested URL /mhonarc/patches/dded9117101d6b0e1b8357066b9df9cd.html was not found on this server.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's On-Demand Production Tuning

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-15-2008, 11:47 PM
Bruce Momjian
 
Posts: n/a
Default Re: Commit fest?

Gregory Stark wrote:
> "Bruce Momjian" <bruce@momjian.us> writes:
>
> > bruce wrote:
> >> > Yea, that is a big problem because the URLs are dynamic. I have the
> >> > comments based on message id but there is no way to hook that to a URL.
> >>
> >> I have modified the code so each email message now shows a _permanent_
> >> URL at the top, e.g.
> >>
> >> Permanent URL: http://momjian.us/mhonarc/patches/44...isedb.com.html

> >
> > I have shortened the URL using md5:
> >
> > Permanent URL: http://momjian.us/mhonarc/patches/dd...66b9df9cd.html
> >
> > So _now_ it is permanent. ;-)

>
> Not Found
> The requested URL /mhonarc/patches/dded9117101d6b0e1b8357066b9df9cd.html was not found on this server.


Yes, sorry, I had to remove the feature. I will re-add it
tomorrow/Sunday.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-15-2008, 11:47 PM
Gregory Stark
 
Posts: n/a
Default Re: Commit fest?

"Bruce Momjian" <bruce@momjian.us> writes:

> Gregory Stark wrote:
>> "Bruce Momjian" <bruce@momjian.us> writes:
>>
>> > bruce wrote:
>> >> > Yea, that is a big problem because the URLs are dynamic. I have the
>> >> > comments based on message id but there is no way to hook that to a URL.
>> >>
>> >> I have modified the code so each email message now shows a _permanent_
>> >> URL at the top, e.g.
>> >>
>> >> Permanent URL: http://momjian.us/mhonarc/patches/44...isedb.com.html
>> >
>> > I have shortened the URL using md5:
>> >
>> > Permanent URL: http://momjian.us/mhonarc/patches/dd...66b9df9cd.html
>> >
>> > So _now_ it is permanent. ;-)

>>
>> Not Found
>> The requested URL /mhonarc/patches/dded9117101d6b0e1b8357066b9df9cd.html was not found on this server.

>
> Yes, sorry, I had to remove the feature. I will re-add it
> tomorrow/Sunday.


Actually, is it just me or has the whole patch queue disappeared?
Everything under /mhonarc/patches seems to be gone.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-15-2008, 11:47 PM
Tom Lane
 
Posts: n/a
Default Re: Commit fest?

Gregory Stark <stark@enterprisedb.com> writes:
> Actually, is it just me or has the whole patch queue disappeared?
> Everything under /mhonarc/patches seems to be gone.


/mhonarc? The URL I've always used is
http://momjian.us/cgi-bin/pgpatches

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-15-2008, 11:47 PM
Gregory Stark
 
Posts: n/a
Default Re: Commit fest?

"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> Gregory Stark <stark@enterprisedb.com> writes:
>> Actually, is it just me or has the whole patch queue disappeared?
>> Everything under /mhonarc/patches seems to be gone.

>
> /mhonarc? The URL I've always used is
> http://momjian.us/cgi-bin/pgpatches


Yeah, but note that all the links in that page including the Next Page go to
/mhonarc. In any case Bruce seems to have regenerated the files.

I'm curious where the comments are being stored, since it's not in the html
source. The javascript must be pulling them from another url?

Also, I think I would prefer you *not* md5sum the message-id. The message-id
is globally unique. Given a message-id we have at least a fighting chance of
finding it in our local mail spool or the Postgres mail archive. (Though the
Postgres search engine doesn't support that currently).

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's Slony Replication support!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-15-2008, 11:47 PM
Bruce Momjian
 
Posts: n/a
Default Re: Commit fest?

Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>
> > Gregory Stark <stark@enterprisedb.com> writes:
> >> Actually, is it just me or has the whole patch queue disappeared?
> >> Everything under /mhonarc/patches seems to be gone.

> >
> > /mhonarc? The URL I've always used is
> > http://momjian.us/cgi-bin/pgpatches

>
> Yeah, but note that all the links in that page including the Next Page go to
> /mhonarc. In any case Bruce seems to have regenerated the files.


Good, should be online now with permanent links too.

> I'm curious where the comments are being stored, since it's not in the html
> source. The javascript must be pulling them from another url?


The comments are stored at JS-Kit:

http://js-kit.com/comments/

> Also, I think I would prefer you *not* md5sum the message-id. The message-id
> is globally unique. Given a message-id we have at least a fighting chance of
> finding it in our local mail spool or the Postgres mail archive. (Though the
> Postgres search engine doesn't support that currently).


Well, I can't have "@" in the URL because it is usually forbidden by
browsers for phishing protection, so I was converting @ to '.' anyway.
What I have now done is display the real message id and MD5 permanent
link at the top of each message, e.g.:

http://momjian.us/mhonarc/patches/msg00054.html

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-15-2008, 11:47 PM
Gregory Stark
 
Posts: n/a
Default Re: Commit fest?

"Bruce Momjian" <bruce@momjian.us> writes:

>> I'm curious where the comments are being stored, since it's not in the html
>> source. The javascript must be pulling them from another url?

>
> The comments are stored at JS-Kit:
>
> http://js-kit.com/comments/


It's stored in their server?

>
> Well, I can't have "@" in the URL because it is usually forbidden by
> browsers for phishing protection, so I was converting @ to '.' anyway.
> What I have now done is display the real message id and MD5 permanent
> link at the top of each message, e.g.:
>
> http://momjian.us/mhonarc/patches/msg00054.html


Any chance we could put that on the actual listing page somehow. perhaps in a
tiny font?? I want to be able to copy the thread and get enough information
for future reference.

Also, any chance you could use the permanent urls in the thread listing?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's RemoteDBA services!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-15-2008, 11:47 PM
Bruce Momjian
 
Posts: n/a
Default Re: Commit fest?

Gregory Stark wrote:
> "Bruce Momjian" <bruce@momjian.us> writes:
>
> >> I'm curious where the comments are being stored, since it's not in the html
> >> source. The javascript must be pulling them from another url?

> >
> > The comments are stored at JS-Kit:
> >
> > http://js-kit.com/comments/

>
> It's stored in their server?


Yes, that was the beauty of it --- I just add javascript with a tag and
all comments are handled by them.

> > Well, I can't have "@" in the URL because it is usually forbidden by
> > browsers for phishing protection, so I was converting @ to '.' anyway.
> > What I have now done is display the real message id and MD5 permanent
> > link at the top of each message, e.g.:
> >
> > http://momjian.us/mhonarc/patches/msg00054.html

>
> Any chance we could put that on the actual listing page somehow. perhaps in a
> tiny font?? I want to be able to copy the thread and get enough information
> for future reference.


You want the message-id on the listing page? Sure, I was doing that
before but I didn't know anyone wanted it and it looked a little
cluttered. Let me know.

> Also, any chance you could use the permanent urls in the thread listing?


Uh, that would be a little tricky because the next/previous wants to go
by message number increment, I think. I could post-process all the HTML
files to do a search/replace.

I think the bigger problem is the threads move around on the thread
pages, and that seems impossible to fix as items are added and removed.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-15-2008, 11:47 PM
Gregory Stark
 
Posts: n/a
Default Re: Commit fest?

"Bruce Momjian" <bruce@momjian.us> writes:

> You want the message-id on the listing page? Sure, I was doing that
> before but I didn't know anyone wanted it and it looked a little
> cluttered. Let me know.


I agree it was too cluttered for normal use.

What I'm trying to do is get a page which has the message-id's of all the
messages and the comments on the same page. That way I can dump the data into
a text file to experiment with.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's Slony Replication support!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 01:48 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com