SEO

#1 (**permalink**) 04-12-2008, 08:46 AM

Is there still a TODO here?

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Fix parameter recalculation for Limit nodes: during a ReScan call we must
> recompute the limit/offset immediately, so that the updated values are
> available when the child's ReScan function is invoked. Add a regression
> test for this, too. Bug is new in HEAD (due to the bounded-sorting patch)
> so no need for back-patch.
>
> I did not do anything about merging this signaling with chgParam processing,
> but if we were to do that we'd still need to compute the updated values
> at this point rather than during the first ProcNode call.
>
> Per observation and test case from Greg Stark, though I didn't use his patch.
>
> Modified Files:
> --------------
> pgsql/src/backend/executor:
> nodeLimit.c (r1.30 -> r1.31)
> (http://developer.postgresql.org/cvsw...1=1.30&r2=1.31)
> nodeSubplan.c (r1.88 -> r1.89)
> (http://developer.postgresql.org/cvsw...1=1.88&r2=1.89)
> pgsql/src/include/nodes:
> execnodes.h (r1.173 -> r1.174)
> (http://developer.postgresql.org/cvsw...1.173&r2=1.174)
> pgsql/src/test/regress/expected:
> limit.out (r1.4 -> r1.5)
> (http://developer.postgresql.org/cvsw...?r1=1.4&r2=1.5)
> pgsql/src/test/regress/sql:
> limit.sql (r1.4 -> r1.5)
> (http://developer.postgresql.org/cvsw...?r1=1.4&r2=1.5)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

#2 (**permalink**) 04-12-2008, 08:46 AM

Bruce Momjian <bruce@momjian.us> writes:
> Is there still a TODO here?

> Tom Lane wrote:
>> Fix parameter recalculation for Limit nodes:

No, it's fixed AFAIK. Till someone finds another bug anyway ;-)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

SEO

Re: [COMMITTERS] pgsql: Fix parameter recalculation for Limit