Unix Technical Forum

Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

This is a discussion on Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author within the pgsql Hackers forums, part of the PostgreSQL category; --> Bruce Momjian wrote: > Log Message: > ----------- > Remove Christof Petig copyright on include file, per author request. ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 02:31 AM
Alvaro Herrera
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

Bruce Momjian wrote:
> Log Message:
> -----------
> Remove Christof Petig copyright on include file, per author request.


Huh, I thought what he actually told was that the file was released
under BSD license. Maybe I missed it, but I didn't see him asking to
remove the copyright.

We certainly have copyrights attributed to individual people. Jan Wieck
has his name on the PL/Tcl and PL/pgSQL files, for example.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 02:31 AM
Alvaro Herrera
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Remove Christof Petig copyright on include file, per author request.

>
> Huh, I thought what he actually told was that the file was released
> under BSD license. Maybe I missed it, but I didn't see him asking to
> remove the copyright.


Also, now that I see the actual diff, I see you only removed the
$PostgreSQL$ tag from ecpg_informix.h. I assume this was unintended.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-12-2008, 02:31 AM
Bruce Momjian
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file,

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Remove Christof Petig copyright on include file, per author request.

>
> Huh, I thought what he actually told was that the file was released
> under BSD license. Maybe I missed it, but I didn't see him asking to
> remove the copyright.
>
> We certainly have copyrights attributed to individual people. Jan Wieck
> has his name on the PL/Tcl and PL/pgSQL files, for example.


We should not have individual copyrights to individuals in our source
tree. If Jan's is in there, it should be removed too (with his
approval). The only copyright holder should be PostgreSQL Global
Development Group.

Jan, would you fix that?

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-12-2008, 02:31 AM
Bruce Momjian
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on

Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove Christof Petig copyright on include file, per author request.

> >
> > Huh, I thought what he actually told was that the file was released
> > under BSD license. Maybe I missed it, but I didn't see him asking to
> > remove the copyright.

>
> Also, now that I see the actual diff, I see you only removed the
> $PostgreSQL$ tag from ecpg_informix.h. I assume this was unintended.
>


Intended. None of the other include files in that directory had it.
Either all should, or none. Should we add it to all of them?

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-12-2008, 02:31 AM
Tom Lane
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Intended. None of the other include files in that directory had it.
> Either all should, or none. Should we add it to all of them?


All. There's no good excuse for not having a version tag on every
source-code file. The contrib stuff is pretty bad about this, but
hey, it's just contrib ;-). ecpg is part of the main tree and it
ought to be up to project standards.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-12-2008, 02:31 AM
Alvaro Herrera
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove Christof Petig copyright on include file, per author request.

> >
> > Huh, I thought what he actually told was that the file was released
> > under BSD license. Maybe I missed it, but I didn't see him asking to
> > remove the copyright.
> >
> > We certainly have copyrights attributed to individual people. Jan Wieck
> > has his name on the PL/Tcl and PL/pgSQL files, for example.

>
> We should not have individual copyrights to individuals in our source
> tree. If Jan's is in there, it should be removed too (with his
> approval). The only copyright holder should be PostgreSQL Global
> Development Group.


Why give all our code to a organisation that doesn't exist?

On the $PostgreSQL$ issue, I think it's best to have the tag everywhere,
so if these files were the only ones that had it, I'd rather add them to
the rest ...

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-12-2008, 02:31 AM
Jim C. Nasby
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

On Wed, Mar 08, 2006 at 07:37:14PM -0300, Alvaro Herrera wrote:
> On the $PostgreSQL$ issue, I think it's best to have the tag everywhere,
> so if these files were the only ones that had it, I'd rather add them to
> the rest ...


+1. I'd also argue that it should be in contrib as well.

I can submit a patch for contrib or the entire tree if desired.
Convention is that it goes near the top of the file, correct?
--
Jim C. Nasby, Sr. Engineering Consultant jnasby@pervasive.com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-12-2008, 02:31 AM
Alvaro Herrera
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

Jim C. Nasby wrote:

> +1. I'd also argue that it should be in contrib as well.
>
> I can submit a patch for contrib or the entire tree if desired.
> Convention is that it goes near the top of the file, correct?


Correct.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-12-2008, 02:31 AM
Jim C. Nasby
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

On Wed, Mar 08, 2006 at 11:27:23PM -0300, Alvaro Herrera wrote:
> Jim C. Nasby wrote:
>
> > +1. I'd also argue that it should be in contrib as well.
> >
> > I can submit a patch for contrib or the entire tree if desired.
> > Convention is that it goes near the top of the file, correct?

>
> Correct.


K, I'll work on everything but contrib tonight.

What do people think about contrib? Yea or nay for enforcing
$PostgreSQL$?
--
Jim C. Nasby, Sr. Engineering Consultant jnasby@pervasive.com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-12-2008, 02:31 AM
Marc G. Fournier
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Remove Christof Petig copyright

On Wed, 8 Mar 2006, Jim C. Nasby wrote:

> On Wed, Mar 08, 2006 at 11:27:23PM -0300, Alvaro Herrera wrote:
>> Jim C. Nasby wrote:
>>
>>> +1. I'd also argue that it should be in contrib as well.
>>>
>>> I can submit a patch for contrib or the entire tree if desired.
>>> Convention is that it goes near the top of the file, correct?

>>
>> Correct.

>
> K, I'll work on everything but contrib tonight.
>
> What do people think about contrib? Yea or nay for enforcing
> $PostgreSQL$?


Any code in our source tree should conform to the same version tagging, so
Yah ...

----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 03:09 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com