Unix Technical Forum

Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

This is a discussion on Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands. within the pgsql Hackers forums, part of the PostgreSQL category; --> Neil Conway wrote: > Log Message: > ----------- > RESET SESSION, plus related new DDL commands. This phrase is ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 08:17 AM
Alvaro Herrera
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

Neil Conway wrote:
> Log Message:
> -----------
> RESET SESSION, plus related new DDL commands.


This phrase is missing a verb:

The default value is defined as the value that the parameter would
have had, if no <command>SET</> ever been issued for it in the
current session.

/pgsql/doc/src/sgml/ref/reset.sgml


I find this markup strange:

<synopsis>
SET SESSION AUTHORIZATION DEFAULT;
RESET ALL;
DEALLOCATE ALL;
CLOSE ALL;
UNLISTEN *;
RESET PLANS;
RESET TEMP;
</synopsis>

shouldn't it be using <programlisting> ?


In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
instead of the SysCache lookup?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 08:17 AM
Neil Conway
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: RESET SESSION, plus related newDDL commands.

On Thu, 2007-04-12 at 11:45 -0400, Alvaro Herrera wrote:
> This phrase is missing a verb:
> [...]
> I find this markup strange:
> [...]
> In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
> instead of the SysCache lookup?


All fair points: I've applied the attached patch. Thanks for the review.

-Neil



---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 10:00 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com