Unix Technical Forum

Re: [COMMITTERS] pgsql: Second try committing the path changes.

This is a discussion on Re: [COMMITTERS] pgsql: Second try committing the path changes. within the pgsql Hackers forums, part of the PostgreSQL category; --> meskes@postgresql.org (Michael Meskes) writes: > Second try committing the path changes. Ah, this looks better. I get clean passes ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 04:14 AM
Tom Lane
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

meskes@postgresql.org (Michael Meskes) writes:
> Second try committing the path changes.


Ah, this looks better. I get clean passes on both HPPA in-tree and
Fedora x86_64 VPATH builds, so I think you've finally fixed all the
issues. Congrats!

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 04:14 AM
Chris Browne
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

tgl@sss.pgh.pa.us (Tom Lane) writes:
> meskes@postgresql.org (Michael Meskes) writes:
>> Second try committing the path changes.

>
> Ah, this looks better. I get clean passes on both HPPA in-tree and
> Fedora x86_64 VPATH builds, so I think you've finally fixed all the
> issues. Congrats!


Ah. So this would have caused a bunch of problems in compiling
src/interfaces/ecpg/test/connect/test1.pgc???

I'm not sure I'm seeing it in CVS; perhaps this waits some time before
getting completely public?
--
let name="cbbrowne" and tld="ntlug.org" in name ^ "@" ^ tld;;
http://www3.sympatico.ca/cbbrowne/languages.html
"Unfortunately, because the wicked sorcerers of Silikonn' Vahlli hated
freedom, they devised clever signs and wonders to achieve the mighty
Captive User Interface, also known as the Prison for Idiot Minds."
-- Michael Peck <mjpeck@nstar.net>
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-12-2008, 04:14 AM
Jaime Casanova
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

On 8/29/06, Chris Browne <cbbrowne@acm.org> wrote:
> tgl@sss.pgh.pa.us (Tom Lane) writes:
> > meskes@postgresql.org (Michael Meskes) writes:
> >> Second try committing the path changes.

> >
> > Ah, this looks better. I get clean passes on both HPPA in-tree and
> > Fedora x86_64 VPATH builds, so I think you've finally fixed all the
> > issues. Congrats!

>
> Ah. So this would have caused a bunch of problems in compiling
> src/interfaces/ecpg/test/connect/test1.pgc???
>
> I'm not sure I'm seeing it in CVS; perhaps this waits some time before
> getting completely public?


i'm seeing this error when compiling HEAD (updated at ago 29 15:16)

make[5]: Entering directory
`/home/postgres/PG_RELEASES/pgsql-8.2uv/src/interfaces/ecpg/test/connect'
.../../preproc/ecpg -I./../../include -o test1.c -I. test1.pgc
test1.pgc:29: ERROR: syntax error at or near "@"
make[5]: *** [test1.c] Error 3
make[5]: *** Deleting file `test1.c'

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-12-2008, 04:15 AM
Chris Browne
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

meskes@postgresql.org (Michael Meskes) writes:
> On Tue, Aug 29, 2006 at 03:35:14PM -0500, Jaime Casanova wrote:
>> >Ah. So this would have caused a bunch of problems in compiling
>> >src/interfaces/ecpg/test/connect/test1.pgc???

>
> Not the compilation errors I would think.
>
>> i'm seeing this error when compiling HEAD (updated at ago 29 15:16)
>> ...

>
> This looks like you're using an old version of the parser. preproc.y was
> changed to handle empty database names and the the error you report is
> due to an empty db name.


I think the problem is that the latest version of preproc.c isn't
based on that version of preproc.y (or perhaps similarly with pgc.l/pgc.c).

If I touch preproc.y and pgc.l, the .c files get regenerated, and all
is well.

If I don't, they get left alone, and I see compilation errors.

It seems to me you need to rebuild the C files and commit them.
--
select 'cbbrowne' || '@' || 'ntlug.org';
http://www3.sympatico.ca/cbbrowne/lsf.html
When I die, I'd like to go peacefully in my sleep like my grandfather,
not screaming in terror like his passengers...
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-12-2008, 04:15 AM
Jaime Casanova
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

On 8/30/06, Michael Meskes <meskes@postgresql.org> wrote:
> On Tue, Aug 29, 2006 at 03:35:14PM -0500, Jaime Casanova wrote:
> > i'm seeing this error when compiling HEAD (updated at ago 29 15:16)
> > ...

>
> This looks like you're using an old version of the parser. preproc.y was
> changed to handle empty database names and the the error you report is
> due to an empty db name.
>


seems, you are right... i had downloaded the entire CVS again and now
all is working fine

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-12-2008, 04:15 AM
Tom Lane
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

Chris Browne <cbbrowne@acm.org> writes:
> If I touch preproc.y and pgc.l, the .c files get regenerated, and all
> is well.


> If I don't, they get left alone, and I see compilation errors.


> It seems to me you need to rebuild the C files and commit them.


No, because those derived files are not in CVS at all. What you
are describing sounds to me like a clock skew problem. Is your
machine's system clock showing the correct date?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-12-2008, 04:16 AM
Chris Browne
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

tgl@sss.pgh.pa.us (Tom Lane) writes:
> Chris Browne <cbbrowne@acm.org> writes:
>> If I touch preproc.y and pgc.l, the .c files get regenerated, and all
>> is well.

>
>> If I don't, they get left alone, and I see compilation errors.

>
>> It seems to me you need to rebuild the C files and commit them.

>
> No, because those derived files are not in CVS at all. What you
> are describing sounds to me like a clock skew problem. Is your
> machine's system clock showing the correct date?


Odd, odd. NOT a clock problem. The .c files were sitting in my
buildfarm's CVS repository for HEAD. And yes, indeed, the derived
files shouldn't have been there at all. I'm not quite sure how they
got there in the first place.

At any rate, after comprehensively looking for yacc-derived files,
that clears this problem, as well as regression failures with last
night's commit of COPY (SELECT) TO, which is no bad thing.
--
(format nil "~S@~S" "cbbrowne" "ntlug.org")
http://www.ntlug.org/~cbbrowne/linux.html
Rules of the Evil Overlord #155. "If I know of any heroes in the land,
I will not under any circumstance kill their mentors, teachers, and/or
best friends." <http://www.eviloverlord.com/>
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-12-2008, 04:17 AM
Tom Lane
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path changes.

Chris Browne <cbbrowne@acm.org> writes:
> tgl@sss.pgh.pa.us (Tom Lane) writes:
>> No, because those derived files are not in CVS at all. What you
>> are describing sounds to me like a clock skew problem. Is your
>> machine's system clock showing the correct date?


> Odd, odd. NOT a clock problem. The .c files were sitting in my
> buildfarm's CVS repository for HEAD. And yes, indeed, the derived
> files shouldn't have been there at all. I'm not quite sure how they
> got there in the first place.


> At any rate, after comprehensively looking for yacc-derived files,
> that clears this problem, as well as regression failures with last
> night's commit of COPY (SELECT) TO, which is no bad thing.


I'll bet the way they got there is you did a build in the CVS repository
tree, and then cleaned up with "make distclean" not "make maintainer-clean".

The buildfarm script is supposed to complain about unexpected files in
the repository --- I wonder if it is fooled by the .cvsignore entries
for these files?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-12-2008, 04:17 AM
Andrew Dunstan
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path

Tom Lane wrote:
> Chris Browne <cbbrowne@acm.org> writes:
>
>> tgl@sss.pgh.pa.us (Tom Lane) writes:
>>
>>> No, because those derived files are not in CVS at all. What you
>>> are describing sounds to me like a clock skew problem. Is your
>>> machine's system clock showing the correct date?
>>>

>
>
>> Odd, odd. NOT a clock problem. The .c files were sitting in my
>> buildfarm's CVS repository for HEAD. And yes, indeed, the derived
>> files shouldn't have been there at all. I'm not quite sure how they
>> got there in the first place.
>>

>
>
>> At any rate, after comprehensively looking for yacc-derived files,
>> that clears this problem, as well as regression failures with last
>> night's commit of COPY (SELECT) TO, which is no bad thing.
>>

>
> I'll bet the way they got there is you did a build in the CVS repository
> tree, and then cleaned up with "make distclean" not "make maintainer-clean".
>
> The buildfarm script is supposed to complain about unexpected files in
> the repository --- I wonder if it is fooled by the .cvsignore entries
> for these files?
>
> regards, tom lane
>
>


Yes, we do. A patch made in July 2005 has this comment:

"ignore files listed in cvsignore files - this will stop inappropriate triggering of vpath builds."


Perhaps I should only do that for vpath builds. Or perhaps I should even
remove them at the end of a build, since we don't expect any of those
files in a clean repo, do we?

Also, in case anyone has not got the message yet: Don't ever build by
hand in the buildfarm repo. Ever. I mean it. Use a copy.

cheers

andrew


---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-12-2008, 04:22 AM
Andrew Dunstan
 
Posts: n/a
Default Re: [COMMITTERS] pgsql: Second try committing the path



Andrew Dunstan wrote:
> Tom Lane wrote:
>>
>> The buildfarm script is supposed to complain about unexpected files in
>> the repository --- I wonder if it is fooled by the .cvsignore entries
>> for these files?
>>

>
> Yes, we do. A patch made in July 2005 has this comment:
>
> "ignore files listed in cvsignore files - this will stop inappropriate
> triggering of vpath builds."
>
>
> Perhaps I should only do that for vpath builds. Or perhaps I should
> even remove them at the end of a build, since we don't expect any of
> those files in a clean repo, do we?
>
> Also, in case anyone has not got the message yet: Don't ever build by
> hand in the buildfarm repo. Ever. I mean it. Use a copy.
>
>


I have just committed a patch that removes the cvsignore trap. This
should be safe as we now remove them at the end of a buildfarm vpath run.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:34 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com