SEO

"Pavel Stehule" <pavel.stehule@gmail.com> writes:
> On 21/01/2008, Devrim GÜNDÜZ <devrim@commandprompt.com> wrote:
>> Orafce is about to be approved for Fedora, and I need help for one of
>> the review items. Per:
>> https://bugzilla.redhat.com/show_bug.cgi?id=251805#c1

AFAICT, there's nothing wrong with the Makefile. The problem is with
the specfile, which apparently is calling plain "make install".
It should read

%install
rm -rf $RPM_BUILD_ROOT

make DESTDIR=$RPM_BUILD_ROOT install

Devrim: you should be testing specfiles by building as non-root;
you would have caught this yourself.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Tom Lane wrote:
> "Pavel Stehule" <pavel.stehule@gmail.com> writes:
>
>> On 21/01/2008, Devrim GÜNDÜZ <devrim@commandprompt.com> wrote:
>>
>>> Orafce is about to be approved for Fedora, and I need help for one of
>>> the review items. Per:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=251805#c1
>>>
>
> AFAICT, there's nothing wrong with the Makefile. The problem is with
> the specfile, which apparently is calling plain "make install".
> It should read
>
> %install
> rm -rf $RPM_BUILD_ROOT
>
> make DESTDIR=$RPM_BUILD_ROOT install
>
> Devrim: you should be testing specfiles by building as non-root;
> you would have caught this yourself.
>
>
>

Shouldn't one always build RPMs as non-root?

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Devrim: you should be testing specfiles by building as non-root;
>> you would have caught this yourself.

> Shouldn't one always build RPMs as non-root?

That'd be my advice --- the other way is archaic, not to mention a
bit of a security risk.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Hi,

On Mon, 2008-01-21 at 11:17 -0500, Tom Lane wrote:
> Devrim: you should be testing specfiles by building as non-root;
> you would have caught this yourself.

Even though it means a lot of work in my current setup, this is what
will happen eventually, especially after the Makefile.regress problem
you found. I should have seen it before.

Regards,
--
Devrim GÜNDÜZ , RHCE
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, ODBCng - http://www.commandprompt.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHlMu2pme12CBXnxERAnqdAKCFC4Nelt2XuFPq9xe4up zaGy8uMQCcCf5r
otylqqWi/rLnshb8WcBgDi0=
=4eVW
-----END PGP SIGNATURE-----

Hi,

On Mon, 2008-01-21 at 11:26 -0500, Andrew Dunstan wrote:
> Shouldn't one always build RPMs as non-root?

Probably, if the packager is not lazy

Regards,

--
Devrim GÜNDÜZ , RHCE
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, ODBCng - http://www.commandprompt.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHlM64pme12CBXnxERAryJAJ9S48T4zWNDbWPnTMtpMv FMXEzcBwCfQA/i
6kUuref1AhgtNAN1zPN2kgw=
=pgds
-----END PGP SIGNATURE-----

> Tom Lane wrote:
>
>> %install
>> rm -rf $RPM_BUILD_ROOT
>>
>> make DESTDIR=$RPM_BUILD_ROOT install

I hope nobody tries building in a directory with a space in it...

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's PostGIS support!

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim@CommandPrompt.com> writes:
> On Mon, 2008-01-21 at 11:26 -0500, Andrew Dunstan wrote:
>> Shouldn't one always build RPMs as non-root?

> Probably, if the packager is not lazy

It's really not hard, it just takes a couple of minutes of one-time
setup. Make a file ~/.rpmmacros containing (in my case)

%_topdir /home/tgl/rpmwork

then create the directory ~/rpmwork and under it the five directories
BUILD/ RPMS/ SOURCES/ SPECS/ SRPMS/

Now you put your SRPMS in ~/rpmwork/SRPMS and run rpmbuild there,
same as you would do in /usr/src/redhat, you're just not root.
Much safer.

(Obviously, you can put your rpmwork directory wherever you want and
call it whatever you want, adjusting the _topdir macro to match.
What I show above is the customary thing for Red Hat engineers,
though.)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Hi,

On Mon, 2008-01-21 at 12:31 -0500, Tom Lane wrote:
> It's really not hard, it just takes a couple of minutes of one-time
> setup.
<snip>

I *know* how to build the RPMs as non root :-) -- we are talking about
~60 servers to be setup like this . That's why it will take a bit time.

I'll try to this asap.

Regards,
--
Devrim GÜNDÜZ , RHCE
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, ODBCng - http://www.commandprompt.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHlNikpme12CBXnxERArKnAJ4yACQS9tDODb5rJDg9A0 Xrpu1ACwCgiRr2
D1QBQhbmGr7EplYKQ0V/oug=
=9v+b
-----END PGP SIGNATURE-----

Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim@CommandPrompt.com> writes:
> I *know* how to build the RPMs as non root :-) -- we are talking about
> ~60 servers to be setup like this . That's why it will take a bit time.

You mean the RPM buildfarm? I would've thought that was already set up
as non-root --- or are you skipping the regression-test step?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Hi,

On Mon, 2008-01-21 at 13:08 -0500, Tom Lane wrote:
> > I *know* how to build the RPMs as non root :-) -- we are talking
> > about ~60 servers to be setup like this . That's why it will take a
> > bit time.
>
> You mean the RPM buildfarm?

Yes.

> I would've thought that was already set up as non-root

No

> --- or are you skipping the regression-test step?

Yes, that's why I could not find out the regression problem before you.

Regards,
--
Devrim GÜNDÜZ , RHCE
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, ODBCng - http://www.commandprompt.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHlOQepme12CBXnxERArr2AKCQNGZvNreUjo7bFhLGEE y3CqtqNgCfcCr+
feJb2+tBT31aakjzWL+nn4M=
=n4P3
-----END PGP SIGNATURE-----