Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> The patch to c.h certainly had no compunction about possibly changing
>> the behavior for Cygwin:

> Maybe we need to divorce Cygwin and Win32.

That seems like probably an overreaction. The impression I got was that
this patch had actually moved the MSVC port quite a long way towards
being like the Cygwin port. It was just sloppy :-(.

Magnus, this was your patch, can you see about fixing the collateral
damage to the Cygwin build?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

>>1) Is any John Franks code really in this file?

Possibly, maybe probably. I don't remember the details (9 years is a
long time!) but almost certainly any code or algorithms were
specifically for the "inside" or "outside" routines.

>>2) Did John provide a separate license for PostgreSQL to license it under
>>the BSD license?

Not explicitly that I can recall.

> This code seems to have been inserted by Tom Lockhart on 1997-07-29
> (geo_ops.c rev 1.13). Tom, any info on the copyright status?

None, beyond the info you already resurrected. I vaguely recall that I
did take the LJ letter as an invitation to reuse algorithms. I would
guess that I had possible licensing conflicts in mind so would have
tried to avoid them, but it would probably be best for someone to
evaluate that from the current code bases. I may have preserved the
Franks info for attribution of concepts to a specific person and version.

My (also vague) recollection is that the original Postgres algorithm was
just broken. I would suggest looking at the code, contacting J. Franks
if there are questions or a need for license clarification or
authorization, and finding an alternative algorithm if necessary.

hth

- Tom

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Thomas Lockhart <lockhart@fourpalms.org> writes:
>> This code seems to have been inserted by Tom Lockhart on 1997-07-29
>> (geo_ops.c rev 1.13). Tom, any info on the copyright status?

> None, beyond the info you already resurrected. I vaguely recall that I
> did take the LJ letter as an invitation to reuse algorithms. I would
> guess that I had possible licensing conflicts in mind so would have
> tried to avoid them, but it would probably be best for someone to
> evaluate that from the current code bases. I may have preserved the
> Franks info for attribution of concepts to a specific person and version.

Thanks for answering, Tom. Charles, since you were the one interested,
maybe you could compare the geo_ops.c code to the Franks code and see
if it looks like Tom borrowed code or just the algorithms?

> My (also vague) recollection is that the original Postgres algorithm was
> just broken.

Yeah, I saw while tracing the CVS history that the code you replaced
defined "overlaps" as "bounding boxes overlap", which is surely not good
enough for polygons ;-)

> I would suggest looking at the code, contacting J. Franks
> if there are questions or a need for license clarification or
> authorization, and finding an alternative algorithm if necessary.

The algorithms are probably public-domain, but we might need a
clean-room implementation :-(

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

> -----Original Message-----
> From: pgsql-hackers-owner@postgresql.org
> [mailtogsql-hackers-owner@postgresql.org] On Behalf Of
> Andrew Dunstan
> Sent: 22 June 2006 23:09
> To: Tom Lane
> Cc: Bort, Paul; pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] [CORE] GPL Source and Copyright Questions
>
>
>
> Something has broken Cygwin in the last 18 days ;-(

Is there any real reason to continue to support Cygwin? We've always
said it's not a first class port, and now we have the native port which
is it seems somewhat pointless expending further effort on it.

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Andrew Dunstan <andrew@dunslane.net> writes:
> Frankly this patch has significant infelicities. For example,
> what is the reason for removing the standard protection
> against double inclusion that header files should usually
> have from pg_config.h.win32?

I've got to admit, I don't recall that. It may be an oversight - I keep
mixing up pg_config.h.win32 and port.h and port/win32.h in my head ;-)

You will notice that the other two of those don't have it.

But it shouldn't be a problem - AFAIK it's only loaded from c.h, and
that one has protection.


> I assume that no test was done to see if this broke Cygwin,
> despite the fact that if you have a Windows box to test on,
> checking that you haven't broken Cygwin should not be too
> difficult..

Given the amount of damage I've seen it do, Cygwin is definitly *not*
making it onto my development machines. So no, I didn't build it on
cygwin. However, I didn't intend for it to break of course - I tried
manual checking. Which I obviously didn't do good enough.

I'll try to set it up in a VM for testing.

> And why do win32 and cygwin now not include at all pg_config_os.h?

It's a way to avoid the step to copy win32\port.h in msvc. configure
copies it to pg_config_os.h. Since for win32 platforms (unfortunatly, at
this point it considers cygwin win32..)that will always be port/win32.h,
it explicitly includes that one instead.


Tom writes:

> Magnus, this was your patch, can you see about fixing the
> collateral damage to the Cygwin build?

Will do. May be a ocuple of days before I can set up a VM with cygwin,
but I'll try to get it done as soon as I can.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Dave Page wrote:

>
>Is there any real reason to continue to support Cygwin? We've always
>said it's not a first class port, and now we have the native port which
>is it seems somewhat pointless expending further effort on it.
>
>
>
>

Some people still use it for development, I believe. Similar arguments
were used against our having the Win32 port in the first place.
Personally I am inclined to support whatever platforms we reasonably
can, and leave the choice to users rather than make it for them.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

On Jun 23, 2006, at 3:10 AM, Dave Page wrote:

> Is there any real reason to continue to support Cygwin? We've always
> said it's not a first class port, and now we have the native port
> which
> is it seems somewhat pointless expending further effort on it.


Are all the tools needed to compile from source on Win32 freely
available?


John DeSoi, Ph.D.
http://pgedit.com/
Power Tools for PostgreSQL


---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Michael Meskes <meskes@postgresql.org> writes:
> On Thu, Jun 22, 2006 at 11:37:08AM -0400, Tom Lane wrote:
>>>> item #3: Carsten Wolff copyright in informix.c file
>>> The file informix.c contains a copyright from Carsten Wolff. Did Carsten
>>> directly contribute this file to the PostgreSQL project?
>>
>> This code was added by Michael Meskes in informix.c rev 1.6
>> (2003-05-06). Michael, any info on the exact copyright status?

> Yes. In fact the copyright belongs to credativ GmbH the company that
> paid Carsten for his work. As you may or may not know I'm the CEO of
> that company and can assure you that his work was contributed to the
> PostgreSQL project.

That sounds fine --- could you add a note in the source code to this
effect? "Contributed under the PostgreSQL License" or something like
that after the copyright notice would be sufficient.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

> -----Original Message-----
> From: John DeSoi [mailto:desoi@pgedit.com]
> Sent: 23 June 2006 14:56
> To: Dave Page
> Cc: Andrew Dunstan; Tom Lane; Bort, Paul; pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] [CORE] GPL Source and Copyright Questions
>
>
> On Jun 23, 2006, at 3:10 AM, Dave Page wrote:
>
> > Is there any real reason to continue to support Cygwin? We've always
> > said it's not a first class port, and now we have the native port
> > which
> > is it seems somewhat pointless expending further effort on it.
>
>
> Are all the tools needed to compile from source on Win32 freely
> available?

Yes. Even when/if we add a VC++ build they will be.

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

"Dave Page" <dpage@vale-housing.co.uk> writes:
> Is there any real reason to continue to support Cygwin? We've always
> said it's not a first class port, and now we have the native port which
> is it seems somewhat pointless expending further effort on it.

I think the day will come when there's a good reason to decommission the
Cygwin port (ie, some problem that seems unreasonably hard to solve),
and then I'll be the first in line voting to do so. But accidental
breakage due to someone being sloppy with #ifdefs for a different port
isn't a good reason.

Actually, my gripe about this one is that it wasn't detected promptly.
That patch went in two weeks ago; we should have known about the problem
within a couple days at most. Seems like the Windows members of the
buildfarm don't run often enough. The whole point of the buildfarm is
to spot problems while the code is still fresh in mind, no?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster