Re: --enable-thread-safety on Win32

> -----Original Message-----
> From: Bruce Momjian [mailtogman@candle.pha.pa.us]
> Sent: 28 July 2005 14:29
> To: Dave Page
> Cc: PostgreSQL-development
> Subject: Re: [HACKERS] --enable-thread-safety on Win32
>
> Dave Page wrote:
> >
> >
> > > -----Original Message-----
> > > From: Bruce Momjian [mailtogman@candle.pha.pa.us]
> > > Sent: 28 July 2005 02:39
> > > To: Dave Page
> > > Cc: PostgreSQL-development
> > > Subject: Re: [HACKERS] --enable-thread-safety on Win32
> > >
> > > Dave Page wrote:
> > > > Did anyone get a chance to think about this? I'd like to
> > > fix this for
> > > > 8.1, but it should also make life easy with the new
> libpq based ODBC
> > > > driver improvements if I can produce an appropriate patch
> > > sooner rather
> > > > than later!
> > >
> > > I have thought about it and it needs to be addressed
> before 8.1 final,
> > > but I don't have time at the moment.
> >
> > I'm happy to work on it if we can agree on the best way forward :-)
>
> Uh, good question. As I remember the issue is that there are too many
> unix-isms in the test program (thread creation) that are not actually
> used in libpq. I would like to see how hard it would be to
> add #ifdefs
> to get the test program to run on Win32.

I did manage to get it to compile (though not work fully just yet),
however I had to use the full pthreads library rather than our minimal
implementation. That's why I question whether we should go this way - an
extra dependency (pthreads is not normally on a Windows box, even with
Msys) to test an OS that we know 100% for sure is not going to vary in
it's thread-safetyness(!) from system to system.

Regards, Dave

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

"Dave Page" <dpage@vale-housing.co.uk> writes:
> From: Bruce Momjian [mailtogman@candle.pha.pa.us]
>> I would like to see how hard it would be to
>> add #ifdefs to get the test program to run on Win32.

> I did manage to get it to compile (though not work fully just yet),
> however I had to use the full pthreads library rather than our minimal
> implementation. That's why I question whether we should go this way - an
> extra dependency (pthreads is not normally on a Windows box, even with
> Msys) to test an OS that we know 100% for sure is not going to vary in
> it's thread-safetyness(!) from system to system.

I agree --- that seems like useless make-work. Just put a special case
for Windows into configure.in and be done with it.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Tom Lane wrote:
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > From: Bruce Momjian [mailtogman@candle.pha.pa.us]
> >> I would like to see how hard it would be to
> >> add #ifdefs to get the test program to run on Win32.
>
> > I did manage to get it to compile (though not work fully just yet),
> > however I had to use the full pthreads library rather than our minimal
> > implementation. That's why I question whether we should go this way - an
> > extra dependency (pthreads is not normally on a Windows box, even with
> > Msys) to test an OS that we know 100% for sure is not going to vary in
> > it's thread-safetyness(!) from system to system.
>
> I agree --- that seems like useless make-work. Just put a special case
> for Windows into configure.in and be done with it.

OK, but I would then like someone to actually run the tests we do in
thread_test.c and make sure they _would_ pass on Win32.

--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings