Unix Technical Forum

Re: Going for "all green" buildfarm results

This is a discussion on Re: Going for "all green" buildfarm results within the pgsql Hackers forums, part of the PostgreSQL category; --> Mark Wong wrote: >> >> Now why are we failing on 7.3? What version of flex do you have? ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-12-2008, 04:06 AM
Andrew Dunstan
 
Posts: n/a
Default Re: Going for "all green" buildfarm results



Mark Wong wrote:

>>
>> Now why are we failing on 7.3? What version of flex do you have? If
>> it's too modern we'll just need to take 7.3 out of the cobra and
>> stoat rotations - we'd really only make supercritical fixes on that
>> branch these days.

>
>
> Flex is 2.5.33 on both systems. I'm assuming that's too modern so
> I'll go ahead and stop building 7.3 for those systems.



You could be lucky the others build. I believe our supported version is
still 2.5.4, which is what all my linux systems have.

cheers

andrew



---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-12-2008, 04:06 AM
Neil Conway
 
Posts: n/a
Default Re: Going for "all green" buildfarm results

On Thu, 2006-06-22 at 12:52 -0400, Andrew Dunstan wrote:
> I believe our supported version is still 2.5.4, which is
> what all my linux systems have.


Its not clear to me why some people have such antipathy toward recent
flex releases, but if our only supported flex version is 2.5.4, I think
this should be documented: the current installation instructions only
say that "Flex 2.5.4 or later" should be used for CVS builds.

-Neil



---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-12-2008, 04:06 AM
Tom Lane
 
Posts: n/a
Default Re: Going for "all green" buildfarm results

Neil Conway <neilc@samurai.com> writes:
> On Thu, 2006-06-22 at 12:52 -0400, Andrew Dunstan wrote:
>> I believe our supported version is still 2.5.4, which is
>> what all my linux systems have.


> Its not clear to me why some people have such antipathy toward recent
> flex releases, but if our only supported flex version is 2.5.4, I think
> this should be documented: the current installation instructions only
> say that "Flex 2.5.4 or later" should be used for CVS builds.


Some of them appear to be actively broken :-(. If we knew exactly which
ones they were, we'd document that, but I don't think we have a handle
on why some 2.5.x flexes barf and others don't.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-12-2008, 04:07 AM
Tom Lane
 
Posts: n/a
Default Re: Going for "all green" buildfarm results

Andrew Dunstan <andrew@dunslane.net> writes:
> Mark Wong wrote:
>> Flex is 2.5.33 on both systems. I'm assuming that's too modern so
>> I'll go ahead and stop building 7.3 for those systems.


> You could be lucky the others build. I believe our supported version is
> still 2.5.4, which is what all my linux systems have.


I checked into this and it seems that what we'd need to do is backport
some subset of these 7.4 changes:

2003-09-13 22:18 tgl

* contrib/seg/: Makefile, README.seg, seg.c, seg.sql.in,
segparse.y, segscan.l, expected/seg.out: Make contrib/seg work with
flex 2.5.31. Fix it up to have a real btree operator class, too,
since in PG 7.4 you can't GROUP without one.

2003-09-13 21:52 tgl

* contrib/cube/: Makefile, README.cube, cube.c, cube.sql.in,
cubeparse.y, cubescan.l, expected/cube.out: Make contrib/cube work
with flex 2.5.31. Fix it up to have a real btree operator class,
too, since in PG 7.4 you can't GROUP without one.

2003-09-14 14:44 tgl

* contrib/: tsearch/parser.l, tsearch2/wordparser/parser.l:
Persuade tsearch/tsearch2 to work (or at least pass their
regression tests) when using flex 2.5.31. The fix is to *not* try
to use palloc and pfree for allocations within the lexer; when you
do that, the yy_buffer_stack gets freed at inopportune times. The
code is already set up to do manual deallocation, so I see no
particular advantage to using palloc anyway.

This is probably not worth doing. We're really only maintaining 7.3 for
legacy platforms (the only one I care about is RHEL3 ;-)) and a legacy
platform is likely to have an old flex. It's a tad annoying to lose
buildfarm coverage on it though ...

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 02:32 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
SEO by vBSEO 3.2.0
www.UnixAdminTalk.com