"Jeremy Kronuz" <kronuz@hotmail.com> writes:
> Hello again,This is an usable version of my EAN13/UPC/ISBN module.

I'm reviewing this for addition to contrib/ now. I notice that there is
no clear license statement. Is it OK to put the following into the
README file?


EAN13 - UPC - ISBN (books) - ISMN (music) - ISSN (serials)
----------------------------------------------------------

Copyright Germán Méndez Bravo (Kronuz), 2004 - 2006
This module is released under the same BSD license as the rest of PostgreSQL.

The information to implement this module was collected through ...


regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Tom Lane wrote:
> "Jeremy Kronuz" <kronuz@hotmail.com> writes:
> > Hello again,This is an usable version of my EAN13/UPC/ISBN module.
>
> I'm reviewing this for addition to contrib/ now. I notice that there is
> no clear license statement. Is it OK to put the following into the
> README file?
>
>
> EAN13 - UPC - ISBN (books) - ISMN (music) - ISSN (serials)
> ----------------------------------------------------------
>
> Copyright Germán Méndez Bravo (Kronuz), 2004 - 2006
> This module is released under the same BSD license as the rest of PostgreSQL.
>
> The information to implement this module was collected through ...

Do we want to go down this road for all submissions? I think saying
nothing is best.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> I'm reviewing this for addition to contrib/ now. I notice that there is
>> no clear license statement. Is it OK to put the following into the
>> README file?

>> This module is released under the same BSD license as the rest of PostgreSQL.

> Do we want to go down this road for all submissions? I think saying
> nothing is best.

The alternative is to ask him to remove his personal copyright notice
and put "Copyright PostgreSQL Global Development Group" instead. I
don't really care which, but without one or the other it's not clear
that he is giving permission for redistribution.

As for "all submissions", I'm only concerned about the ones that come
plastered with copyright notices.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> I'm reviewing this for addition to contrib/ now. I notice that there is
> >> no clear license statement. Is it OK to put the following into the
> >> README file?
>
> >> This module is released under the same BSD license as the rest of PostgreSQL.
>
> > Do we want to go down this road for all submissions? I think saying
> > nothing is best.
>
> The alternative is to ask him to remove his personal copyright notice
> and put "Copyright PostgreSQL Global Development Group" instead. I
> don't really care which, but without one or the other it's not clear
> that he is giving permission for redistribution.

Agreed.
>
> As for "all submissions", I'm only concerned about the ones that come
> plastered with copyright notices.

Oh, I didn't see one in there. Oh, I see it now in isn.c:

* Copyright (c) 2004-2006, Germ<E1>n M<E9>ndez Bravo (Kronuz)

And when you said "I notice that there is no clear license statement", I
thought you meant no license at all.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

>
>"Jeremy Kronuz" <kronuz@hotmail.com> writes:
> > Hello again,This is an usable version of my EAN13/UPC/ISBN module.
>
>I'm reviewing this for addition to contrib/ now. I notice that there is
>no clear license statement. Is it OK to put the following into the
>README file?
>
>
>EAN13 - UPC - ISBN (books) - ISMN (music) - ISSN (serials)
>----------------------------------------------------------
>
>Copyright Germán Méndez Bravo (Kronuz), 2004 - 2006
>This module is released under the same BSD license as the rest of
>PostgreSQL.
>
>The information to implement this module was collected through ...

Tom, yes. Also, I just put copyright in the files that contain a significant
amount of code written by me. (i.e. isn.h and isn.c).
If you check the other files, I just put the information was recompiled from
several sources and I also included the websites from where the information
came.

I suppose I just forgot to put the BSD license legend there in the code, so
please add the line you suggested about the PostgreSQL BSD license if you
want.

Also, did you get the 'isn-1_0_beta_20060924' version from my ftp? 'cause
that’s the last one I updated (2006-09-24). It's at:
ftp://ftp.kronuz.com/pub/programming...060924.tar.bz2 (just in
case)

Kronuz.



---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

"Jeremy Kronuz" <kronuz@hotmail.com> writes:
>> I'm reviewing this for addition to contrib/ now. I notice that there is
>> no clear license statement. Is it OK to put the following into the
>> README file?

> Tom, yes. Also, I just put copyright in the files that contain a significant
> amount of code written by me. (i.e. isn.h and isn.c).

Excellent, thanks.

> Also, did you get the 'isn-1_0_beta_20060924' version from my ftp? 'cause
> that’s the last one I updated (2006-09-24). It's at:
> ftp://ftp.kronuz.com/pub/programming...060924.tar.bz2 (just in
> case)

You had submitted two slightly different versions to the mailing list
awhile back. I took the one that seemed to have later file dates and
did some fixes/editorializations on that. Please look at what I've
just committed to PG CVS and see if you want to make any adjustments
--- if so, submit a patch through the usual pgsql-patches channel.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

I also added other functionality to the module but I forgot to update the
README... contrary to what it says in the README.isn, you do can cast from
ean13 to other types, as long as the cast is valid (i.e. you can't cast a
EAN13 of a UPC or a ISMN code to a ISBN number, for instance.)

So, the text starting at line 184 in the README.isn should say something
like this instead:

-- note that you can only cast from ean13 to other type when the casted
-- number would be valid in the realm of the casted type;
-- thus, the following will NOT work: select isbn(ean13('0220356483481'));
-- but these will:
select upc(ean13('0220356483481'));
select ean13(upc('220356483481'));

(this is not in my patch, I just realized about this)

Kronuz.
"Fools rush in where fools have been before" – Unknown



---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq