SEO
vBulletin Search Engine Optimization
| |||||||
| Register | FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
04-15-2008, 09:02 PM
| ||||
| ||||
 Re: IsTransactionState() is being used incorrectly Is this done or should it be kept for 8.4? --------------------------------------------------------------------------- Tom Lane wrote: > I just noticed that there are a number of places (mostly GUC assignment > hooks) that use IsTransactionState() to decide if it's safe for them to > do catalog lookups. This seems pretty bogus because IsTransactionState > will return true in an aborted transaction. I'm not sure there's any > actual bug because of other constraints on when GUC updates occur, but > it sure looks like trouble waiting to happen. > > We could fix this either by changing the definition of > IsTransactionState() or by introducing another test function with > a different name. Any thoughts which is preferable? > > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 2: Don't 'kill -9' the postmaster -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings      |
|
04-15-2008, 09:02 PM
| ||||
| ||||
| Re: IsTransactionState() is being used incorrectly Bruce Momjian <bruce@momjian.us> writes: > Tom Lane wrote: >> We could fix this either by changing the definition of >> IsTransactionState() or by introducing another test function with >> a different name. Any thoughts which is preferable? > Is this done or should it be kept for 8.4? Fixed, I thought ... yeah, here: 2007-06-07 17:45 tgl * src/backend/: access/transam/xact.c, storage/ipc/procarray.c, utils/error/elog.c: Redefine IsTransactionState() to only return true for TRANS_INPROGRESS state, which is the only state in which it's safe to initiate database queries. It turns out that all but two of the callers thought that's what it meant; and the other two were using it as a proxy for "will GetTopTransactionId() return a nonzero XID"? Since it was in fact an unreliable guide to that, make those two just invoke GetTopTransactionId() always, then deal with a zero result if they get one. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq |
Linear Mode
